Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor contract #2306

Merged
merged 15 commits into from
Dec 4, 2024
Merged

Conversation

zmcNotafraid
Copy link
Collaborator

No description provided.

@zmcNotafraid zmcNotafraid requested a review from rabbitz December 3, 2024 10:42
Signed-off-by: Miles Zhang <[email protected]>
Copy link

codecov bot commented Dec 3, 2024

Codecov Report

Attention: Patch coverage is 31.78571% with 191 lines in your changes missing coverage. Please review.

Project coverage is 58.03%. Comparing base (f373f6b) to head (a2a9384).
Report is 545 commits behind head on develop.

Files with missing lines Patch % Lines
...rs/analyze_contract_from_cell_dependency_worker.rb 0.00% 82 Missing ⚠️
lib/tasks/migration/fill_contracts_info.rake 14.28% 24 Missing ⚠️
...ill_cell_dependency_block_number_and_tx_index.rake 14.81% 23 Missing ⚠️
lib/tasks/migration/fill_cell_deps_out_point.rake 13.04% 20 Missing ⚠️
app/workers/contract_statistic_worker.rb 0.00% 16 Missing ⚠️
app/controllers/api/v2/scripts_controller.rb 53.12% 15 Missing ⚠️
app/models/contract.rb 78.94% 4 Missing ⚠️
lib/scheduler.rb 0.00% 3 Missing ⚠️
app/models/ckb_sync/transactions.rb 0.00% 1 Missing ⚠️
app/models/lock_script.rb 85.71% 1 Missing ⚠️
... and 2 more

❗ There is a different number of reports uploaded between BASE (f373f6b) and HEAD (a2a9384). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (f373f6b) HEAD (a2a9384)
2 1
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2306      +/-   ##
===========================================
- Coverage    67.56%   58.03%   -9.53%     
===========================================
  Files          289      358      +69     
  Lines         7944    10366    +2422     
===========================================
+ Hits          5367     6016     +649     
- Misses        2577     4350    +1773     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zmcNotafraid zmcNotafraid force-pushed the refactor-contract branch 2 times, most recently from ed4f43b to a5b5693 Compare December 4, 2024 06:27
@zmcNotafraid zmcNotafraid added this pull request to the merge queue Dec 4, 2024
Merged via the queue into nervosnetwork:develop with commit 82dd84f Dec 4, 2024
1 of 3 checks passed
@zmcNotafraid zmcNotafraid deleted the refactor-contract branch December 4, 2024 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants