Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bind first mint cota's cell id to cota collection #1868

Merged
merged 2 commits into from
May 21, 2024

Conversation

zmcNotafraid
Copy link
Collaborator

No description provided.

@zmcNotafraid zmcNotafraid requested a review from rabbitz May 21, 2024 06:25
Copy link

codecov bot commented May 21, 2024

Codecov Report

Attention: Patch coverage is 41.66667% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 63.72%. Comparing base (7d6b7a1) to head (457f5ff).

Current head 457f5ff differs from pull request most recent head f91c68a

Please upload reports for the commit f91c68a to get more accurate results.

Files Patch % Lines
app/workers/fetch_cota_worker.rb 40.00% 6 Missing ⚠️
app/services/cota_aggregator.rb 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1868      +/-   ##
===========================================
- Coverage    63.73%   63.72%   -0.01%     
===========================================
  Files          344      344              
  Lines         9415     9421       +6     
===========================================
+ Hits          6001     6004       +3     
- Misses        3414     3417       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zmcNotafraid zmcNotafraid added this pull request to the merge queue May 21, 2024
Merged via the queue into nervosnetwork:develop with commit 3e53bbe May 21, 2024
1 check passed
@zmcNotafraid zmcNotafraid deleted the issue-664-3 branch May 21, 2024 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants