Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove published: true limit when udpate api token info #1555

Conversation

zmcNotafraid
Copy link
Collaborator

No description provided.

@codecov-commenter
Copy link

Codecov Report

Attention: 168 lines in your changes are missing coverage. Please review.

Comparison is base (bb447e4) 66.37% compared to head (1c652a3) 67.09%.
Report is 188 commits behind head on develop.

❗ Current head 1c652a3 differs from pull request most recent head f34d1f8. Consider uploading reports for the commit f34d1f8 to get more accurate results

Files Patch % Lines
app/workers/charts/ckb_hodl_waves_statistic.rb 0.00% 45 Missing ⚠️
.../controllers/api/v2/ckb_transactions_controller.rb 67.56% 24 Missing ⚠️
app/workers/token_transfer_detect_worker.rb 10.52% 17 Missing ⚠️
app/workers/contract_statistic_worker.rb 0.00% 15 Missing ⚠️
app/controllers/api/v2/scripts_controller.rb 69.76% 13 Missing ⚠️
app/models/ckb_sync/new_node_data_processor.rb 72.34% 13 Missing ⚠️
app/models/concerns/display_cells.rb 92.68% 6 Missing ⚠️
app/services/das_indexer_service.rb 0.00% 6 Missing ⚠️
app/workers/update_address_info_worker.rb 0.00% 6 Missing ⚠️
app/controllers/api/v2/nft/transfers_controller.rb 71.42% 4 Missing ⚠️
... and 11 more
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1555      +/-   ##
===========================================
+ Coverage    66.37%   67.09%   +0.71%     
===========================================
  Files          275      285      +10     
  Lines         7397     7741     +344     
===========================================
+ Hits          4910     5194     +284     
- Misses        2487     2547      +60     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zmcNotafraid zmcNotafraid added this pull request to the merge queue Jan 8, 2024
Merged via the queue into nervosnetwork:develop with commit 789be08 Jan 8, 2024
1 check passed
@zmcNotafraid zmcNotafraid deleted the update-api-token-remove-published-limit branch January 8, 2024 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants