Skip to content

Commit

Permalink
feat: xudt tag length must less than 60 (#2146)
Browse files Browse the repository at this point in the history
Signed-off-by: Miles Zhang <[email protected]>
  • Loading branch information
zmcNotafraid authored Aug 26, 2024
1 parent e6de418 commit 449fd8e
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 4 deletions.
4 changes: 2 additions & 2 deletions app/workers/xudt_tag_worker.rb
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ class XudtTagWorker
include Sidekiq::Job

def perform
udts = Udt.published_xudt.left_joins(:xudt_tag).where(xudt_tag: { id: nil }).limit(100)
udts = Udt.published_xudt.left_joins(:xudt_tag).where(xudt_tag: { id: nil }).where.not(issuer_address: nil).limit(100)
if !udts.empty?
attrs =
udts.map do |udt|
Expand Down Expand Up @@ -46,7 +46,7 @@ def invisible_char?(symbol)
end

def out_of_length?(symbol)
symbol.length > 5 || symbol.length < 4
symbol.length > 60
end

def first_xudt?(symbol, block_timestamp)
Expand Down
6 changes: 5 additions & 1 deletion test/factories/udt.rb
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,11 @@
symbol { "kfc" }
decimal { 6 }
h24_ckb_transactions_count { 0 }
issuer_address do
script = CKB::Types::Script.new(code_hash: Settings.secp_cell_type_hash, args: "0x#{SecureRandom.hex(20)}",
hash_type: "type")
CKB::Address.new(script).generate
end

trait :with_transactions do
after(:create) do |udt, _evaluator|
Expand Down Expand Up @@ -71,6 +76,5 @@
symbol { "XC" }
decimal { 8 }
end

end
end
2 changes: 1 addition & 1 deletion test/workers/xudt_tag_worker_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ class XudtTagWorkerTest < ActiveJob::TestCase
end

test "insert out-of-length-range tag" do
create(:udt, :xudt, symbol: "CK BBBB")
create(:udt, :xudt, symbol: "CKBBBB" * 11)
assert_changes -> { XudtTag.count }, from: 0, to: 1 do
XudtTagWorker.new.perform
end
Expand Down

0 comments on commit 449fd8e

Please sign in to comment.