fix: compatibility with newer ckb-cli #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
blckngm
commented
Sep 22, 2022
blckngm
commented
- Remove --wait-for-sync arg when calling ckb-cli
- Remove fields that no longer exists in LiveCellInfoVec
TheWaWaR
reviewed
Sep 22, 2022
| @@ -114,7 +113,6 @@ impl Collector { | |||
| .arg("--url") | |||
| .arg(&self.api_uri) | |||
| .arg("wallet") | |||
| .arg("--wait-for-sync") | |||
There was a problem hiding this comment.
The --ckb-indexer-url argument is needed.
There was a problem hiding this comment.
Didn't notice this because I have run ckb-cli interactively before and there are saved urls.
This argument will need to be added to capsule deploy too and passed to ckb-cli?
There was a problem hiding this comment.
Yes, just like the argument --url above.
|
Is this PR ready for merge? |
I think so. Please review. |
TheWaWaR
approved these changes
Sep 26, 2022
|
Please rebase and sign all your commits. |
* Remove --wait-for-sync arg when calling ckb-cli * Remove fields that no longer exists in LiveCellInfoVec * Add --ckb-indexer-url arg to deploy command It could also be specified with environment variable CKB_INDEXER_URL. And the --api arg can be specified with the API_URL environment variable now. (These environment variable names are consistent with ckb-cli.)
blckngm
force-pushed
the
ckb-cli-compatibility
branch
from
366cdca to
4aa6742
Compare
Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.