Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use cross and xshell #106

Merged
merged 3 commits into from
Apr 24, 2023
Merged

Use cross and xshell #106

merged 3 commits into from
Apr 24, 2023

Conversation

blckngm
Copy link
Collaborator

@blckngm blckngm commented Apr 24, 2023

Close #84, #87, #97, #104.

Xshell makes writing program invocation code easier. And it increases transparency by printing out the command to invoke.

@blckngm blckngm marked this pull request as ready for review April 24, 2023 05:16
@blckngm blckngm requested a review from jjyr as a code owner April 24, 2023 05:16
@jjyr
Copy link
Collaborator

jjyr commented Apr 24, 2023

We should provide installation commands in the README to lower the bar.

blckngm added 3 commits April 24, 2023 19:42
* to support unit tests in contracts
* and to avoid duplicated lang items error with rust-analyzer

  (by default rust-analyzer enables the test target)
to improve transparency and simplify code
@jjyr jjyr added this pull request to the merge queue Apr 24, 2023
Merged via the queue into nervosnetwork:develop with commit ccd6a7c Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants