Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Docker builds for nerves_system_br v1.28.0 and later #996

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

fhunleth
Copy link
Member

@fhunleth fhunleth commented Jul 27, 2024

Fixes #997

@fhunleth fhunleth force-pushed the fix-docker-build branch 3 times, most recently from 91ef406 to 73a8769 Compare July 27, 2024 21:07
@fhunleth
Copy link
Member Author

@jjcarstens I think this PR works for nerves_system_br 1.28.x. At least it works on my one test. I'm getting this error with earlier systems and I think it's something else:

➜  nerves_system_bbb git:(v2.22.1) ✗ mix compile
==> nerves
Compiling 2 files (.ex)
Generated nerves app
==> nerves_system_bbb
Generated nerves_system_bbb app
|Elixir.Docker| Starting Build... (this may take a while)

** (Mix) The Nerves Docker build_runner encountered an error while building:

-----
Setting User
UID: 501
GID: 20
useradd: warning: the home directory /home/nerves already exists.
useradd: Not copying any file from skel directory into it.
Switching user
error: exec: "/nerves/env/platform/create-build.sh": stat /nerves/env/platform/create-build.sh: no such file or directory

-----

@fhunleth
Copy link
Member Author

Now I can't reproduce the issue I was seeing. I upgraded Docker on my laptop since I had an old version, and I cleaned the build directory. Maybe it was the latter.

I'm going to mark this as ready for review since it seems to work.

@fhunleth fhunleth marked this pull request as ready for review July 28, 2024 12:46
@fhunleth fhunleth merged commit 9518b14 into main Jul 29, 2024
5 checks passed
@fhunleth fhunleth deleted the fix-docker-build branch July 29, 2024 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docker permissions issue
3 participants