Introduce the ability to add multiple wireless network configurations #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add `add_network/2`, `remove_all_networks/1`, and `reassociate/1` functions to give more fine grained control over the configuration and activation process while shielding callers from implementation details, and reworks `set_network/2` to use the new methods. Add documentation for `:priority` which is useful when configuring Multiple networks.
fhunleth
approved these changes
May 10, 2018
|
What are the chances of getting this merged into master soon? |
ConnorRigby
approved these changes
Nov 29, 2018
|
Sorry for taking so long to get this merged. Looks great to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to nerves-project-attic/nerves_network#72.
Add
add_network/2,remove_all_networks/1, andreassociate/1functions to give more fine grained control over the configuration and
activation process while shielding callers from implementation details,
and reworks
set_network/2to use the new methods.Add documentation for
:prioritywhich is useful when configuringMultiple networks.