Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle strings for the :key_mgmt option #17

Closed
fhunleth opened this issue Aug 14, 2017 · 1 comment
Closed

Handle strings for the :key_mgmt option #17

fhunleth opened this issue Aug 14, 2017 · 1 comment

Comments

@fhunleth
Copy link
Contributor

One of the most common typos reported on the slack channel is typing the following:

key_mgmt: "WPA-PSK"

instead of:

key_mgmt: :"WPA-PSK"

It seems like this could easily be fixed by making the key_mgmt be a string rather than an atom. To avoid breaking old code, we should still support atoms.

Hermanverschooten added a commit to Hermanverschooten/nerves_network that referenced this issue Sep 24, 2017
As mentioned in nerves-project-attic#17, nerves_network does not currently allow for
strings as the key_mgmt method, this PR fixes this by converting
them to atoms as required by nerves_wpa_supplicant.
fhunleth pushed a commit that referenced this issue Oct 10, 2017
As mentioned in #17, nerves_network does not currently allow for
strings as the key_mgmt method, this PR fixes this by converting
them to atoms as required by nerves_wpa_supplicant.
@ConnorRigby
Copy link
Contributor

This is fixed now. See this comment for potential api breaking issues on later versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants