Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow creating a realm browser with only a Realm path #4

Merged
merged 1 commit into from
Mar 19, 2015

Conversation

segiddins
Copy link
Contributor

No description provided.

@@ -8,6 +8,16 @@

static NSString *CellIdentifier = @"CellIdentifier";

@interface RLMRealm ()
+ (instancetype)realmWithPath:(NSString *)path
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why should we use a private method here? Because of the dynamic property?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exactly

-Samuel E. Giddins

On Mar 19, 2015, at 12:00 AM, Piet Brauer [email protected] wrote:

In Pod/Classes/NBNRealmBrowser.m:

@@ -8,6 +8,16 @@

static NSString *CellIdentifier = @"CellIdentifier";

+@interface RLMRealm ()
++ (instancetype)realmWithPath:(NSString *)path
Why should we use a private method here? Because of the dynamic property?


Reply to this email directly or view it on GitHub.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How likely is it to change? Because the removed headers also came all of a sudden. What value does it add?

@segiddins
Copy link
Contributor Author

It's part of our dynamic API, which will eventually become public. It allows you to just open a browser from a file, without that file needing to belong to the application that's doing the opening.

@pietbrauer
Copy link
Member

Ah nice, ok. Will merge it then. And make a minor release.

pietbrauer added a commit that referenced this pull request Mar 19, 2015
Allow creating a realm browser with only a Realm path
@pietbrauer pietbrauer merged commit dfb2ad3 into nerdishbynature:master Mar 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants