Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed old operation processors #1821

Merged
merged 1 commit into from
Jun 25, 2024
Merged

Conversation

Raalsky
Copy link
Contributor

@Raalsky Raalsky commented Jun 19, 2024

Before submitting checklist

  • Did you update the CHANGELOG? (not for test updates, internal changes/refactors or CI/CD setup)
  • Did you ask the docs owner to review all the user-facing changes?

Copy link

codecov bot commented Jun 19, 2024

Codecov Report

Attention: Patch coverage is 77.77778% with 4 lines in your changes missing coverage. Please review.

Project coverage is 78.22%. Comparing base (b8d4580) to head (1fb0685).

Files Patch % Lines
src/neptune/core/operation_processors/factory.py 75.00% 2 Missing ⚠️
...peration_processors/offline_operation_processor.py 66.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1821      +/-   ##
==========================================
- Coverage   81.94%   78.22%   -3.72%     
==========================================
  Files         212      210       -2     
  Lines        9498     9226     -272     
==========================================
- Hits         7783     7217     -566     
- Misses       1715     2009     +294     
Flag Coverage Δ
macos 76.50% <77.77%> (-0.69%) ⬇️
py3.10 ?
py3.11 ?
py3.12 ?
py3.8 76.63% <77.77%> (-0.64%) ⬇️
py3.9 ?
ubuntu 76.50% <77.77%> (-4.17%) ⬇️
unit 76.63% <77.77%> (-0.69%) ⬇️
windows 76.59% <77.77%> (-3.97%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@AleksanderWWW AleksanderWWW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Raalsky
Copy link
Contributor Author

Raalsky commented Jun 21, 2024

Are those failures in e2e expected?

Will be fixed once Project will be restored and basic sync 😉

@Raalsky Raalsky merged commit e7650ad into master Jun 25, 2024
5 of 11 checks passed
@Raalsky Raalsky deleted the rj/remove-old-operation-processors branch June 25, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants