Skip to content

Commit

Permalink
Fixed default params for getAttributesWithPathsFilter (#1740)
Browse files Browse the repository at this point in the history
  • Loading branch information
Raalsky authored Apr 15, 2024
1 parent b6325fd commit 5595eb7
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 2 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@
- Added `setuptools` to dependencies for `python >= 3.12` ([#1721](https://github.com/neptune-ai/neptune-client/pull/1721))
- Fixed compatibility checks with pre-release versions ([#1730](https://github.com/neptune-ai/neptune-client/pull/1730))
- Added `Accept` and `Accept-Encoding` headers to protocol buffer requests ([#1736](https://github.com/neptune-ai/neptune-client/pull/1736))
- Fixed default params for getAttributesWithPathsFilter ([#1740](https://github.com/neptune-ai/neptune-client/pull/1740))


## neptune 1.10.0
Expand Down
10 changes: 8 additions & 2 deletions src/neptune/internal/backends/hosted_neptune_backend.py
Original file line number Diff line number Diff line change
Expand Up @@ -1180,7 +1180,6 @@ def get_fields_with_paths_filter(
"attributeQuery": {
"attributePathsFilter": paths,
},
**DEFAULT_REQUEST_KWARGS,
}

try:
Expand All @@ -1196,7 +1195,14 @@ def get_fields_with_paths_filter(
data = ProtoAttributesDTO.FromString(result)
return [Field.from_proto(field) for field in data.attributes]
else:
data = self.leaderboard_client.api.getAttributesWithPathsFilter(**params).response().result
data = (
self.leaderboard_client.api.getAttributesWithPathsFilter(
**params,
**DEFAULT_REQUEST_KWARGS,
)
.response()
.result
)
return [Field.from_model(field) for field in data.attributes]
except HTTPNotFound as e:
raise ContainerUUIDNotFound(
Expand Down

0 comments on commit 5595eb7

Please sign in to comment.