Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding logic to allow config to be specified for kubeadm init #313

Merged
merged 3 commits into from
Dec 11, 2024

Conversation

dkosteck
Copy link
Contributor

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test

/kind feature

/kind flake

What this PR does / why we need it:
Adding logic to allow config to be specified for kubeadm init, quotes around K8s version (causing failures on certain platforms), and disable swap on Ubuntu.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Copy link
Contributor

nephio-prow bot commented Nov 18, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@dkosteck dkosteck marked this pull request as ready for review December 5, 2024 20:32
@efiacor
Copy link
Contributor

efiacor commented Dec 9, 2024

/test e2e-kubeadm-ubuntu-jammy
/test e2e-kubeadm-fedora-38


- name: Read kubeadm config
ansible.builtin.set_fact:
kubeadm_config_data: "{{ lookup('file', kubeadm_config) | from_yaml }}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unbound variable on kubeadm_config

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah thanks, will take a look at this later today when I have some time

@efiacor
Copy link
Contributor

efiacor commented Dec 11, 2024

/test e2e-oai-fedora-34
/test e2e-free5gc-fedora-34
/test e2e-oai-ubuntu-jammy

@efiacor
Copy link
Contributor

efiacor commented Dec 11, 2024

/override e2e-oai-fedora-34

Copy link
Contributor

nephio-prow bot commented Dec 11, 2024

@efiacor: Overrode contexts on behalf of efiacor: e2e-oai-fedora-34

In response to this:

/override e2e-oai-fedora-34

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@efiacor
Copy link
Contributor

efiacor commented Dec 11, 2024

/approve

@nephio-prow nephio-prow bot added the approved label Dec 11, 2024
@liamfallon
Copy link
Member

/approve
/lgtm

Copy link
Contributor

nephio-prow bot commented Dec 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: efiacor, liamfallon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nephio-prow nephio-prow bot merged commit adaad40 into nephio-project:main Dec 11, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants