-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding logic to allow config to be specified for kubeadm init #313
Adding logic to allow config to be specified for kubeadm init #313
Conversation
Skipping CI for Draft Pull Request. |
/test e2e-kubeadm-ubuntu-jammy |
|
||
- name: Read kubeadm config | ||
ansible.builtin.set_fact: | ||
kubeadm_config_data: "{{ lookup('file', kubeadm_config) | from_yaml }}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unbound variable on kubeadm_config
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah thanks, will take a look at this later today when I have some time
/test e2e-oai-fedora-34 |
/override e2e-oai-fedora-34 |
@efiacor: Overrode contexts on behalf of efiacor: e2e-oai-fedora-34 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/approve |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: efiacor, liamfallon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Adding logic to allow config to be specified for kubeadm init, quotes around K8s version (causing failures on certain platforms), and disable swap on Ubuntu.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: