Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernizing golangci-lint configuration for latest version syntax #726

Merged
merged 1 commit into from
Apr 30, 2024

Conversation

radoslawc
Copy link
Contributor

Golangci-lint config syntax has changed in recent version, this removes warning messages from logs:

level=warning msg="[config_reader] The configuration option `run.skip-files` is deprecated, please use `issues.exclude-files`."
level=warning msg="[config_reader] The configuration option `run.skip-dirs` is deprecated, please use `issues.exclude-dirs`."

Timeout is now config defined not command-line switch

@liamfallon
Copy link
Member

/approve
/lgtm

Copy link
Contributor

nephio-prow bot commented Apr 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liamfallon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nephio-prow nephio-prow bot added the approved label Apr 30, 2024
@nephio-prow nephio-prow bot merged commit aea1e11 into nephio-project:main Apr 30, 2024
5 checks passed
PrimalPimmy pushed a commit to 5GSEC/nephio that referenced this pull request Aug 2, 2024
…phio-project#726)

Golangci-lint config syntax has changed in recent version, this removes
warning messages from logs:
```
level=warning msg="[config_reader] The configuration option `run.skip-files` is deprecated, please use `issues.exclude-files`."
level=warning msg="[config_reader] The configuration option `run.skip-dirs` is deprecated, please use `issues.exclude-dirs`."
```
Timeout is now config defined not command-line switch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants