Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Nephio to Go 1.22 #597

Merged
merged 4 commits into from
May 14, 2024

Conversation

liamfallon
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:
/kind bug

/kind cleanup

/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:

  • Updated go version in go.mod files
  • Updated go version in github workflows
  • Updated base image to 1.22.2-bookworm in Dockerfiles
  • Updated Go/Golang-CI/GoSec versions in makefiles
  • Updated reflect.TypeOf() to reflect.TypeFor where relevant

Which issue(s) this PR fixes:
Fixes Issue 510.

Special notes for your reviewer:

Does this PR introduce a user-facing change?:
no

Copy link
Contributor

nephio-prow bot commented Apr 23, 2024

@liamfallon: The label(s) kind/cleanup cannot be applied, because the repository doesn't have them.

In response to this:

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:
/kind bug

/kind cleanup

/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:

  • Updated go version in go.mod files
  • Updated go version in github workflows
  • Updated base image to 1.22.2-bookworm in Dockerfiles
  • Updated Go/Golang-CI/GoSec versions in makefiles
  • Updated reflect.TypeOf() to reflect.TypeFor where relevant

Which issue(s) this PR fixes:
Fixes Issue 510.

Special notes for your reviewer:

Does this PR introduce a user-facing change?:
no

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nephio-prow nephio-prow bot requested review from henderiw and s3wong April 23, 2024 12:52
@liamfallon
Copy link
Member Author

The go tests need to be upgraded to Go 1.22, see nephio-project/test-infra#258

@liamfallon
Copy link
Member Author

/hold

@liamfallon
Copy link
Member Author

/retest

2 similar comments
@liamfallon
Copy link
Member Author

/retest

@radoslawc
Copy link
Contributor

/retest

nephio-prow bot pushed a commit that referenced this pull request Apr 27, 2024
golangci-lint update to work with go 1.22 updated other components as
well
This resolves failing tests in
#597 and
#722
@liamfallon
Copy link
Member Author

/retest

@liamfallon
Copy link
Member Author

The toolchain has been updated for go 1.22 now, thanks to @radoslawc. This PR is ready for review.
/assign @tliron @efiacor @vjayaramrh

@efiacor
Copy link
Contributor

efiacor commented Apr 29, 2024

/approve

Copy link
Contributor

nephio-prow bot commented Apr 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: efiacor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nephio-prow nephio-prow bot added the approved label Apr 29, 2024
@efiacor
Copy link
Contributor

efiacor commented May 14, 2024

/lgtm

@nephio-prow nephio-prow bot added the lgtm label May 14, 2024
@nephio-prow nephio-prow bot merged commit c165a09 into nephio-project:main May 14, 2024
9 checks passed
PrimalPimmy pushed a commit to 5GSEC/nephio that referenced this pull request Aug 2, 2024
golangci-lint update to work with go 1.22 updated other components as
well
This resolves failing tests in
nephio-project#597 and
nephio-project#722
PrimalPimmy pushed a commit to 5GSEC/nephio that referenced this pull request Aug 2, 2024
**What type of PR is this?**

> Uncomment only one /kind <> line, hit enter to put that in a new line,
and remove leading whitespaces from that line:
>  /kind bug

/kind cleanup

> /kind design
> /kind documentation
> /kind failing-test
> /kind feature
> /kind flake

**What this PR does / why we need it:**

- Updated go version in go.mod files
- Updated go version in github workflows
- Updated base image to 1.22.2-bookworm in Dockerfiles
- Updated Go/Golang-CI/GoSec versions in makefiles
- Updated reflect.TypeOf() to reflect.TypeFor[]() where relevant

**Which issue(s) this PR fixes:**
Fixes [Issue 510](nephio-project#510).

**Special notes for your reviewer:**

**Does this PR introduce a user-facing change?:**
no
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to Go 1.22
5 participants