-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade Nephio to Go 1.22 #597
Upgrade Nephio to Go 1.22 #597
Conversation
@liamfallon: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
The go tests need to be upgraded to Go 1.22, see nephio-project/test-infra#258 |
/hold |
/retest |
2 similar comments
/retest |
/retest |
1fdcd03
to
4077abe
Compare
e52bae8
to
43da889
Compare
/retest |
The toolchain has been updated for go 1.22 now, thanks to @radoslawc. This PR is ready for review. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: efiacor The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
golangci-lint update to work with go 1.22 updated other components as well This resolves failing tests in nephio-project#597 and nephio-project#722
**What type of PR is this?** > Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line: > /kind bug /kind cleanup > /kind design > /kind documentation > /kind failing-test > /kind feature > /kind flake **What this PR does / why we need it:** - Updated go version in go.mod files - Updated go version in github workflows - Updated base image to 1.22.2-bookworm in Dockerfiles - Updated Go/Golang-CI/GoSec versions in makefiles - Updated reflect.TypeOf() to reflect.TypeFor[]() where relevant **Which issue(s) this PR fixes:** Fixes [Issue 510](nephio-project#510). **Special notes for your reviewer:** **Does this PR introduce a user-facing change?:** no
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes Issue 510.
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
no