Adding tests for the error.go resource #530
Conversation
Signed-off-by: Catalin Stratulat <[email protected]>
|
Hi @Catalin-Stratulat-Ericsson. Thanks for your PR. I'm waiting for a nephio-project member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/assign lapentad |
|
/ok-to-test |
There was a problem hiding this comment.
Minor comment but we should try to use the imperative form in the commit message etc.
https://www.gitkraken.com/learn/git/best-practices/git-commit-message#:~:text=Using%20Imperative%20Verb%20Form,fix%E2%80%9D%20and%20%E2%80%9Cupdated%E2%80%9D.
| } | ||
| } | ||
|
|
||
| func TestIsAPIError(t *testing.T) { |
There was a problem hiding this comment.
We can prob remove this as we get full coverage with the next test
Signed-off-by: Catalin Stratulat <[email protected]>
|
/lgtm |
|
/approve |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: henderiw, liamfallon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This is my first commit. adding tests for "nephio\controllers\pkg\resource\error.go" --------- Signed-off-by: Catalin Stratulat <[email protected]>
This is my first commit. adding tests for "nephio\controllers\pkg\resource\error.go"