Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cork lr #230

Merged
merged 15 commits into from
Nov 20, 2019
Merged

Cork lr #230

merged 15 commits into from
Nov 20, 2019

Conversation

meleg
Copy link
Contributor

@meleg meleg commented Oct 11, 2019

In this PR the low-rank data structure for the CORK pencil is implemented.

Here is the checklist: (transferred from #227)

  • matrix-types has to be decoupled in CORK_pencil
  • better names to XXLinearization-types (or restructure it)
  • verification (plot the eigenvalue error as function of number of terms in the expansion)
  • implement low-rank COR_pencil_structure
  • documentation
  • tests
  • remove / lessen duplication of code: nleigs_coefficients.jl and method_nleigs.jl
  • remove the file nep_transformations.jl (check that all was transferred to NEPTransformations.jl)

@meleg meleg mentioned this pull request Oct 11, 2019
@jarlebring
Copy link
Member

I suggest we try to wrap up all CORK-related things in this PR. So I moved the checklist.

@jarlebring
Copy link
Member

All checkboxes checked except two which can be done in a separate PR.

@jarlebring jarlebring merged commit 25712ac into master Nov 20, 2019
@eringh eringh deleted the cork_lr branch November 21, 2019 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants