Eigsolver refactor #213
Merged
Eigsolver refactor #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The plan was to introduce creator-objects for eigenvalue problems as in #193. This PR does not do that for the reason I explain below. It does some related cleanup and renaming after which I think #193 can be seen as closed.
The situation for eigenvalue problems is a bit different from linear systems. The strong need for prefactorization (with LU- or preconditioner computation) for linear systems is not the same for eigenvalue problems. I can see no common use-case where a prefactorization is needed for the eigenvalue based methods. Currently, we send in a type, and an
EigenSolver-object is created every time an eigenvalue problem should be solved. I think we can keep it like it is.It is still possible to do precomputation with the current setup if you create your own type and take care of storing precomputed data yourself. I think this is acceptable considering how rare the situation is. Adding a creator-object setup would add a lot of code, which would be very rarely used.