Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of Logger #182

Merged
merged 52 commits into from
Jun 25, 2019
Merged

Implementation of Logger #182

merged 52 commits into from
Jun 25, 2019

Conversation

jarlebring
Copy link
Member

@jarlebring jarlebring commented Jun 17, 2019

This is an attempt to incorporate a logging functionality #170.

As a user: You can use the new logger kwarg for the NEP-solver:

  • If logger is an Int, it will behave as displaylevel before, under the hood a PrintLogger is instantiated.
  • If logger <: Logger one can obtain more detailed control of what is printed and one can store iteration info in the logger object.

As a NEP-method developer:

  • push_info!(logger,"text") can be used to dump info to the logger. If the logger is a PrintLogger "text" will just be printed. Note that you can add variables by using the dollar sign: "x=$x"

  • push_iteration_info(logger,iter,kwargs...) can be used to push information about iteration iter. kwargs include things such as err, v, etc

  • method_newton

  • iar tiar

  • ErrorLogger storing information

  • rfi

  • nlar

  • infbilanczos

  • contour integrals

  • nleigs

  • sgiter

  • mslp

  • jd

  • ilan

  • broyden (w inner solves)

  • block newton

  • unit tests

  • comments + documentation

Done with: a level parameter: At the moment I am not sure how to handle iar and other methods which compute many eigenvalues. Just printing all the eigval approximations by default would be give too many printouts, but we want this information when we want to study the method (e.g convergence diagrams).

@jarlebring
Copy link
Member Author

Okay. Starting to feel ready with this PR.

@eringh
Copy link
Member

eringh commented Jun 24, 2019

I agree. It starts to be ready to merge.

@jarlebring
Copy link
Member Author

I like it. Time to merge.

@jarlebring jarlebring merged commit 381d674 into master Jun 25, 2019
@eringh eringh deleted the logger branch June 25, 2019 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants