-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementation of Logger #182
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sync with master
sync w master
Okay. Starting to feel ready with this PR. |
I agree. It starts to be ready to merge. |
I like it. Time to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to incorporate a logging functionality #170.
As a user: You can use the new
logger
kwarg for the NEP-solver:logger
is an Int, it will behave as displaylevel before, under the hood aPrintLogger
is instantiated.logger <: Logger
one can obtain more detailed control of what is printed and one can store iteration info in thelogger
object.As a NEP-method developer:
push_info!(logger,"text")
can be used to dump info to the logger. If the logger is a PrintLogger "text" will just be printed. Note that you can add variables by using the dollar sign: "x=$x"push_iteration_info(logger,iter,kwargs...)
can be used to push information about iterationiter
. kwargs include things such aserr
,v
, etcmethod_newton
iar tiar
ErrorLogger storing information
rfi
nlar
infbilanczos
contour integrals
nleigs
sgiter
mslp
jd
ilan
broyden (w inner solves)
block newton
unit tests
comments + documentation
Done with: a level parameter:
At the moment I am not sure how to handleiar
and other methods which compute many eigenvalues. Just printing all the eigval approximations by default would be give too many printouts, but we want this information when we want to study the method (e.g convergence diagrams).