method_beyn: compute eigvecs from the SVD as in Beyn's paper #163
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the eigvec extractions in method_beyn, to be based on more precisely what is proposed in Beyn's paper, i.e. use the singular vectors. I also removed the kwarg
compute_eigenvectors
so we always compute eigenvectors. The eigenvector computation is cheap in comparison to everything else in the algorithm, so I don't see any reason it should be optional here.Preparing to handle #162 and #154.
Could you give an Okay, @eringh?