Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

method_beyn: compute eigvecs from the SVD as in Beyn's paper #163

Merged
merged 4 commits into from
Feb 22, 2019

Conversation

jarlebring
Copy link
Member

@jarlebring jarlebring commented Feb 16, 2019

This changes the eigvec extractions in method_beyn, to be based on more precisely what is proposed in Beyn's paper, i.e. use the singular vectors. I also removed the kwarg compute_eigenvectors so we always compute eigenvectors. The eigenvector computation is cheap in comparison to everything else in the algorithm, so I don't see any reason it should be optional here.

Preparing to handle #162 and #154.

Could you give an Okay, @eringh?

@jarlebring jarlebring requested a review from eringh February 16, 2019 08:28
@jarlebring jarlebring changed the title method_beyn: compute eigvecs from SVD in Beyn's paper method_beyn: compute eigvecs from the SVD as in Beyn's paper Feb 16, 2019
@jarlebring jarlebring assigned jarlebring and unassigned jarlebring Feb 19, 2019
@jarlebring jarlebring merged commit 8518e39 into master Feb 22, 2019
@jarlebring jarlebring deleted the beyn_eigvec_extraction branch February 22, 2019 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant