Updates to loading screen, check dashboard settings #484
Conversation
This commit refactors the App.razor file to improve readability and ensures code standards consistency. Direct changes involve renaming the `transitionClass` variable to `_transitionClass`. The block conditions are spaced properly enhancing code readability. The `HandleLocationChanged` function has also been refactored for improved simplicity and readability. These changes do not alter the functionality of the code but intend to make the code cleaner, easier to read, and maintain.
|
Thank you so much for this PR, this is exactly what I meant! I don't see any loading activity going on when the LoadingScreen component disappears. Great job! The transition classes look really good as well. Thanks a lot for your contribution! Kind regards, |
|
@bakes82 @Bram1903 |
|
@Bram1903 how can we reopen this PR so we can continue development until this issue is resolved? |
You can't, a new PR needs to be opened for that, but that's fine. I'm not exactly sure, but I think it was his intention to make the loading screen appear on every page navigation. Besides that, something seems to be wrong when trying to disable the LoadingScreen in the settings now, since the entire application stays frozen when disabling the loading screen in the settings. |
In app.razor checked for setting
Component updated to take in IsLoaded, so you can use to block long running tasks in other pages/elements.
The loader will now appear for "first render" duration based on the param setting. (frist render is full page loads)
I also added example for on navigation change so every page toggle you will see it for small duration.
Nav manager is injected so you could in first render check the page for your auth url and then not show it 2nd time.
I also left comments for a more "basic" screen fade (set the is loaded to true or remove the component from app.razor)
//transitionClass = "loadScreen-fade-out";
transitionClass = "";