Resolve Font Size Adjustment Discrepancy Across Cultures #470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added CultureInfo.InvariantCulture to double.Parse in ThemesMenu.razor.cs and LayoutService.cs to ensure consistent parsing of the default font size between different cultures. This fix is intended to prevent issues that might arise due to different decimal notations in different cultures.
Updated the CleanArchitecture Blazor solution template version to 1.0.0-preview.10. This new version resolved a discrepancy involved with font size adjustment across different cultures.
|
Thank you. |
I'm still in Norway, however the weather is so bad the last past days that I started coding on my laptop 😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request focuses on resolving a problem related to inconsistent font size adjustment behavior in the ThemesMenu.razor.cs and LayoutService.cs files for various cultural settings. While an initial attempt was made to address this by incorporating CultureInfo.InvariantCulture into the double.Parse calls, it did not produce the intended outcomes when compared to font size adjustments using the default culture.
This issue has now been successfully rectified thanks to @KindlMichal
@neozhu, can you review this?