Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

format for chat problem #267

Closed
Owyn opened this issue Dec 9, 2016 · 22 comments
Closed

format for chat problem #267

Owyn opened this issue Dec 9, 2016 · 22 comments

Comments

@Owyn
Copy link
Contributor

Owyn commented Dec 9, 2016

tera_screenshot_20161208_234208
tera_screenshot_20161208_234119

<header>Damage Done @ {encounter} {timer} {partyDps} {enrage}:\</header>
<content>{class} - {name}: {global_dps} ({damage_percentage}) {debuff_list}\</content>
        <low_dps_content>{class} - {name}: {global_dps} ({damage_percentage}) {debuff_list}\</low_dps_content>

These are same results from my format and old default format

Could you fix it so parameters in {} would all be under each other like in old default version without debuff_list?

(if that is not possible - Can I use {debuff_list} in the <header> to be displayed once and not individually? - would that make chat formatting work OK again?)

@Gl0
Copy link
Collaborator

Gl0 commented Dec 9, 2016

Are you using default chat font?

@Owyn
Copy link
Contributor Author

Owyn commented Dec 9, 2016

Verdana, but look at 1st screen - it formats perfectly with old default formatting

@Gl0
Copy link
Collaborator

Gl0 commented Dec 9, 2016

tera_screenshot_20161210_002841
Fresh screenshot with default-like settings and font
Changed template to:

        <header>---------------- Damage Done @ {encounter} {timer} | {partyDps} | {enrage}:\</header>
        <content>{class} - {name}: {damage_percentage} | {damage_dealt} | {crit_rate} Crit | {dps} | Slaying {slaying} | {debuff_list}\</content>
        <low_dps_content>{class} - {name}: {debuff_list}\</low_dps_content>
        <low_dps_threshold>6</low_dps_threshold>
        <footer></footer>
        <order_by>damage_percentage</order_by>
        <order>descending</order>

tera_screenshot_20161210_004219

@Owyn
Copy link
Contributor Author

Owyn commented Dec 9, 2016

But can you fix it for not default settings?

@Gl0
Copy link
Collaborator

Gl0 commented Dec 9, 2016

With your settings looks fine too.
Don't see
untitled
this issue (look at space before class name).
And can't see, how it can appear with current code.

@Gl0
Copy link
Collaborator

Gl0 commented Dec 9, 2016

Found out, where's the case - your chat is too stretched, and when some string wraps to the next line game reformat string to be justified. And this justification is different for different string content.
Try to resize chat with pasted stats and you'll see the root of problem.

@Gl0
Copy link
Collaborator

Gl0 commented Dec 9, 2016

Ok for adding {debuff_list} to header.

@Gl0 Gl0 closed this as completed in 8cd02a8 Dec 9, 2016
@Owyn
Copy link
Contributor Author

Owyn commented Dec 13, 2016

Ok for adding {debuff_list} to header.

thx, btw, I just noticed in config file there is a <footer> also.. can I add it there?

@Gl0
Copy link
Collaborator

Gl0 commented Dec 13, 2016

only in next release =)

@Gl0 Gl0 reopened this Dec 13, 2016
@Owyn
Copy link
Contributor Author

Owyn commented Dec 13, 2016

In header {debuff_list} include enrage, so you can replace {enrage} with {debuff_list}.

why does it include enrage btw? In footer it would be bad to just duplicate enrage from header, and in header users could just use {enrage} {debuff_list} instead of just {debuff_list} to get the same result, why not?

@Gl0
Copy link
Collaborator

Gl0 commented Dec 13, 2016

Cause it's impossible to make template, where {enrage} will be separated visually only if {debuff_list} is not empty. Enrage is the same debuff as others, showing it the same way looks reasonable.

@Owyn
Copy link
Contributor Author

Owyn commented Dec 13, 2016

Enrage is the same debuff as others

That's weird, I thought it's just a state of boss, not a buff or debuff

But even so - can you just make an exception to cut it out of debuff_list template manually?

@Gl0
Copy link
Collaborator

Gl0 commented Dec 13, 2016

We store it as debuff. Exception can be done, of cause (it's already cut in personal {debuff_list})
Are you sure that it wouldn't be good in current way if we implement short names for debuffs? + (may be) sort it so that enrage goes first?

@Owyn
Copy link
Contributor Author

Owyn commented Dec 13, 2016

It's better in my opinion to display enrage time separately after boss total fight time,

I'm planning on using {debuff_list} in the <footer> so it would be a duplicate if there was an enrage time there

but anyway, even if it would be used in <header> by anyone - {enrage} {debuff_list} would display the pretty same result, no? - but it would give more flexibility, which is nice

@Gl0
Copy link
Collaborator

Gl0 commented Dec 13, 2016

{enrage} is only %, without name and separator = not the same result

@Owyn
Copy link
Contributor Author

Owyn commented Dec 13, 2016

{enrage} is only %, without name and separator = not the same result

Well, if in debuff_list it is something like "enrage %n" user can always add text "enrage" before {enrage} to get the 100% same result

@Gl0
Copy link
Collaborator

Gl0 commented Dec 13, 2016

but he can't set separator =) that is visible only if other debuff listed.

@Owyn
Copy link
Contributor Author

Owyn commented Dec 13, 2016

but he can't set separator

he also can't do that when adding debuff_list per player, or anywhere else... it's not necessary that everyone would want debuff_list to be exactly after enrage timer

  • if it's placed right after enrage, user can write | manually, cuz it's highly unlikely that boss had no debuffs at all (party usually consists of a tank and a healer who both give debuffs)

writing a separator before debuff_list would be a good alternative (if there were other {params} before it as a solution

Gl0 added a commit that referenced this issue Dec 13, 2016
…ents in debuff_list without exact times #270

Removed enrage % from {debuff_list} #267
Add {debuff_list} and {debuff_list_p} placeholders to the footer for those, who want to see all debuffs below dps stats.
Replace full debuff name with short debuff name in paste string if override file exists in meter db.
@Owyn
Copy link
Contributor Author

Owyn commented Dec 24, 2016

btw, on the topick,
tera_screenshot_20161222_185345

the lining up in the end of the screen seems pretty weird, can you fix (remove) it?
I mean those spaces after % sign (0% ) instead of (0%)

@Gl0
Copy link
Collaborator

Gl0 commented Dec 24, 2016

I remove only whitespaces at the end of the string. I can't determine, what user wanted to get, a stripped space in (0% ) or some sort of table like |0% |.
There are some problems with stripping spaces only from last placeholder, since it can be different for normal and low_dps templates.
Or there can be empty or not {debuff_list} at the end.
So I suggest just change (value) to simple |value , that would be looking quite good

@Owyn
Copy link
Contributor Author

Owyn commented Dec 25, 2016

Well, I had to remove [] brackets from class list because this algorithm placed spaces into those, eg [Archer ], why not just make it [Archer] . - place spaces after brackets only? You probably could whitelist brackets so no spaces would be put inside them

@Gl0
Copy link
Collaborator

Gl0 commented Dec 25, 2016

I'll move all spaces that are before ) or ] to be after them. It can brake some wide templates with spaces between brackets, but seems it wouldn't be harmful, since such templates are very uncommon.

Gl0 added a commit that referenced this issue Dec 25, 2016
@Gl0 Gl0 closed this as completed Jan 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants