refactor: add warning to deprecated functions

[dundargoc]

warnings and functions will be removed for 0.7.0 in a followup PR.

[ii14]

Maybe instead of removing vim.lsp.diagnostics, an error could be thrown with some helpful message like Use vim.diagnostic.something().

[gpanders]

Maybe instead of removing vim.lsp.diagnostics, an error could be thrown with some helpful message like Use vim.diagnostic.something().

Yes I think this is the better approach (although I would suggest a warning rather than an error).

vim.api.nvim_echo({{'This method is deprecated. Use {replacement} instead', 'WarningMsg'}}, true, {})

And this needs to make it into a full release before we completely remove these. I had wanted to do something like this for the 0.6 release but never got around to it :( So this deprecation warning will be in 0.7 and they can be fully removed in 0.8. That's a long timeline, but that's plenty of runway to ensure we don't pull the rug out from people too quickly.

[clason]

Compromise: add those warnings to the top of each deprecated function in a different PR now and backport to 0.6.1.

After 0.6.1 is released, we can merge this PR and turn the warnings into errors (prettied up via __index metatable or not).

[clason]

Also, tests would need adapting.

[zeertzjq]

There are no tests that depend on deprecated APIs, so I think tests don't need adapting.

[clason]

Yes, with the new approach of adding a warning to instead of completely removing the deprecated functions, the tests should not need any changes.

[gpanders]

I think save() should be marked deprecated as well (I can't remember why I only marked it as @private).

[gpanders]

/backport

[github-actions]

Cannot read property 'match' of null

[clason]

/backport release-0.6

[github-actions]

Git push to origin failed for release-0.6 with exitcode 1

[github-actions]

Git push to origin failed for release-0.6 with exitcode 1

[github-actions]

Git push to origin failed for release-0.6 with exitcode 1

[github-actions]

Git push to origin failed for release-0.6 with exitcode 1

[github-actions]

Git push to origin failed for release-0.6 with exitcode 1

[gpanders]

/backport

[github-actions]

Cannot read property 'match' of null

[clason]

/backport

[github-actions]

Successfully created backport PR #16575 for release-0.6.

[github-actions]

Git push to origin failed for release-0.6 with exitcode 1

[gpanders]

For posterity (and any curious passers by wondering at the carnage that occurred here): empty PR descriptions will cause the backport workflow to fail with Cannot read property 'match' of null (korthout/backport-action#175). Always describe your PRs kids!