Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolved issues #56 and #57: added sourceContentType and pulling FB photos #80

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

Resolved issues #56 and #57: added sourceContentType and pulling FB photos #80

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
827cf71
Added new model SourceContentType to link Source and ContentType mode…
pulpopurpura Aug 7, 2017
957c425
Corrections to acess FB photos
pulpopurpura Aug 14, 2017
b30f128
Changes as per pull request review: set indentation to 2 spaces, remo…
pulpopurpura Aug 16, 2017
2227cd7
Correct ESLint errors from 'npm run test'; remove references to sourc…
pulpopurpura Aug 17, 2017
5b87b61
Edit .eslintrc.js to implement new ESLint rules (prior to making furt…
pulpopurpura Aug 21, 2017
8f10be7
Edit .eslintrc.js to implement new ESLint rules (add /space-before-fu…
pulpopurpura Aug 21, 2017
5fe7233
Further correct ESLint errors (controllers/item.js, lib/jsonapi.js)
pulpopurpura Aug 21, 2017
702dac2
Further correct ESLint errors and further configure .eslintrc (no-mul…
pulpopurpura Aug 22, 2017
cace2ea
Further correct ESLint errors and further configure .eslintrc (no-mul…
pulpopurpura Aug 22, 2017
2c4d9e3
Add new ESLint rules to put space inside brackets {};
pulpopurpura Aug 27, 2017
f9ea3dd
Remove .DS_Store files;
pulpopurpura Aug 27, 2017
ce8a544
Make changes as per code review:
pulpopurpura Aug 28, 2017
44a89c6
Correct errors resulting from refactoring code to reflect changing re…
pulpopurpura Sep 16, 2017
0b9c6c9
Fix ESLint Test Errors
pulpopurpura Oct 8, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 28 additions & 0 deletions .eslintrc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,34 @@ module.exports = {
"semi": [
"warn",
"always"
],
"key-spacing": [
"warn"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's make this error instead of warn so issues don't slip through?

],
"func-call-spacing": [
"error",
"never"
], "block-spacing": [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's put all value declarations on its own line.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

"error"
],
"array-bracket-spacing": [
"error"
], "keyword-spacing": [
"error"
],
"semi-spacing": [
"error"
], "arrow-spacing": [
"error"
],
"no-tabs": [
"error"
],
"space-before-function-paren": [
"error",
"never"
]

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These extra lines should be removed. Can you check to see if there is an ESLint to check for extraneous lines inside of objects such as here? And is it possible for ESLint to check its own configuration file?


}
};
4 changes: 3 additions & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,6 @@
.cert*
.env*
data*
node_modules
node_modules
.DS_Store
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These two lines should not be in the repo's .gitignore file but rather set as global ignores because they are system-specific, not app-specific: https://help.github.com/articles/ignoring-files/#create-a-global-gitignore

.idea/**
2 changes: 1 addition & 1 deletion Gruntfile.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ module.exports = function(grunt) {
},
nodemon: {
dev: {
script: 'app/server.js'
script: 'app/server.js',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This trailing comma should be removed. Is there an ESLint rule to check automatically for trailing commas such as here?

}
},
symlink: {
Expand Down
Binary file added app/.DS_Store
View file
Open in desktop
Binary file not shown.
Loading