-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More emoji groups and subgroups #7
Comments
I've written a simple parser for the Once #6 has been merged I will create a PR that updates everything to Unicode 12.0 and adds more (sub)groups. |
That's not a bad idea, but it's going to be a bit more complicated than that because the purpose of the .NET Core is of course cross-platform, so the choice of Segoe UI as the font that determines whether or not a glyph is supported is no longer a no-brainer. It should probably be factored out to either a property of the font/platform or a separate table specifically for the font. In all cases, we definitely should extend |
I don't really get why the step with filtering emoji is necessary. OR if you run a newer version of Windows (Insider Previews/...) you wouldn't have access to all emojis since they were not supported on your PC. Also it makes the collection incomplete. I'm a fan of providing all possibilities to the user and he should then decide in his app if he/she likes to keep/show those unsupported emojis or not. Regarding the the |
I'm not sure if you realized, but the filtered emoji list is only in addition to the full emoji list. Think about when it would be necessary to show a list of all emoji (vs looking up an emoji by its unicode sequence or vice versa). The context is a native application providing an interface for a user to enter an emoji into an input by presenting a list of emoji. You would never want to show an emoji that does not render, displays as a tofu, or displays broken as two separate emoji rather than the intended single emoji. The reason why this is precompiled into the application is that it is resource intensive to determine whether or not an emoji can be correctly rendered as a single glyph in a particular font, and there's no native way of figuring that out at runtime in a cross-platform manner without introducing some serious (unmanaged!) dependencies. Of course no one is required or even asked to use the filtered list of emoji rather than the full list in developing your application - but the list is there for those that need such a feature. I have some updates for the importer locally committed that I need to push out. The importer itself doesn't need a lot of work, and updating to a newer version of the Unicode spec is as simple as replacing the There's also significant logic in the importer to create the list of keywords from the names of emoji, to convert emoji names to useful and friendly symbol names, etc. all of which was only developed because it was necessary and isn't there just for show. I'm more than happy to adapt the importer to include the subgroup info; I'm just debating whether or not to introduce separate lists for each subgroup or to include the subgroup as a property of the emoji. |
Btw. I think you should remove the |
Nice. I just pushed some commits with major updates to the parser, including added support for group and subgroup. I haven't updated the C# assets yet. I have a few concerns regarding keeping these lists in memory at all times. I've actually been wondering if it's not better to change the Most likely the best compromise is for them to be dynamically generated on first access and then cached thereafter. |
* Add items previouly elided due to name conflicts (e.g. UpButton2) * Add group and subgroup properties to `SingleEmoji` (see #7) * Automate code generation (supporting both web and headless node)
I would suggest splitting up all emojis in their groups and subgroups like it's done here.
At the moment we only have
All
andBasic
.I think I could extend the emoji-importer.html for this.
The text was updated successfully, but these errors were encountered: