Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify initialization of db connection and nullability in SqliteCache #7

Merged
merged 1 commit into from
Apr 6, 2022

Conversation

AntonyCorbett
Copy link
Contributor

Avoid the null-forgiving operator for _db and Commands by initializing both in the ctor. No change in functionality here.

@mqudsi mqudsi merged commit bd4468b into neosmart:master Apr 6, 2022
@mqudsi
Copy link
Member

mqudsi commented Apr 6, 2022

Hello Antony,

I've merged this w/ some changes to minimize diffs against master. I'll commit the nullability annotations separately.

Thanks for your contribution!

@mqudsi
Copy link
Member

mqudsi commented Apr 6, 2022

On second thought, SetBulkAsync() may handle null input but the API doesn't really want to be called with a null parameter and that would bind us to handling that in the future (whereas now we would be within our rights to throw an ArgumentNullException).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants