BUGFIX: Remove duplicate focus ckeditor border #3847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With neos/neos-development-collection#3618 the legacy ember css class `.neos-inline-editable` was removed (previously set here: https://github.com/neos/neos-development-collection/blob/881675b91185cbd8c41cb5e64f7467bf78710e04/Neos.Neos/Classes/Service/ContentElementEditableService.php#L69) This leads to the ckeditor focus outline styling not being removable. Instead, we use `[data-__neos-property][contenteditable]` to target ckeditor inline elements now.
|
Apparently this also fixes a similar glitch on windows as reported on slack where there is a white outline:
which is set by the user-agent
|
|
To be totally sure i just retested this on a Neos UI version: v7.3.19 and can confirm that this fully restores the original behaviour, that includes NO outline being shown in focus mode and only on hover. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With neos/neos-development-collection#3618 the legacy ember css class
.neos-inline-editablewas removed (previously set here: https://github.com/neos/neos-development-collection/blob/881675b91185cbd8c41cb5e64f7467bf78710e04/Neos.Neos/Classes/Service/ContentElementEditableService.php#L69)This leads to the default ckeditor focus outline styling not being removable.
Instead, we use
[data-__neos-property][contenteditable]to target ckeditor inline elements now.What I did
How I did it
How to verify it