BUGFIX: Prevent unneccessary server calls when inline editor is unchanged #3833
Conversation
| @@ -74,6 +74,14 @@ export default ({store, globalRegistry, nodeTypesRegistry, inlineEditorRegistry, | |||
| actions.Changes.persistChanges([change]) | |||
| ), | |||
| onChange: value => { | |||
| const node = selectors.CR.Nodes.byContextPathSelector(contextPath)(store.getState()); | |||
There was a problem hiding this comment.
i though hey why not use the transientValues ... but we only calculate this dirty state for the inspector ... so i guess this is the way ;) ...
a possibly 'cleaner'? in terms of not - depending - on the node - here - and doing it before onChange called - alternative could be to track what the ckeditor changed currently via change:data and depending on this invoke the callback?
There was a problem hiding this comment.
While probably possible, I wouldn't regard it as cleaner. Tracking CKEditor state is a whole can of worms in its own right, especially since we are only interested in changes that happened since the last time the property was focused.
Checking for actual changes before doing the remote call on the other hand always makes sense - and renders all tracking on CKEditor level moot. I was actually surprised that we didn't do that already 😅
There was a problem hiding this comment.
okay you got me mostly convinced ... i just dislike callback - in this case the onChange - being fired when they simply shouldnt.
Nothing changed if we defocus a not - dirty - ckeditor (maybe ckeditor even has a flag for this?) so thats what i was referring to being "cleaner".
But still seb approved as well so feel free to merge ;)
There was a problem hiding this comment.
Thank you so much for investigating so quickly ;) It makes totally sense that it fails currently because of this new line: https://github.com/neos/neos-ui/pull/3751/files#diff-f2abb91e96ac7035f92ab489c0b6393a31683dadd9f5d3946e4cecab5b9e5373R62
fixes: #3832
Straight-forward fix: This PR adds a check to prevent calls to the change API when the inline editor is unchanged.