Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUGFIX Fix Neos.Ui version information in build script #3825

Merged
merged 2 commits into from
Jul 8, 2024

Conversation

mhsdesign
Copy link
Member

@mhsdesign mhsdesign commented Jul 4, 2024

Resolves: #3781

it will show "UI version: 9.0.3" for tagged builds from neos-ui-compiled and "UI version: 9.0-dev" when requiring dev-9.0 of neos-ui-compiled

@mhsdesign mhsdesign requested a review from Sebobo July 4, 2024 14:22
@github-actions github-actions bot added the 8.3 label Jul 4, 2024
Copy link
Contributor

@grebaldi grebaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@mhsdesign mhsdesign changed the title BUGFIX fix neos ui version label BUGFIX Fix Neos.Ui version information in build script Jul 8, 2024
@Sebobo Sebobo merged commit 6bc407d into 8.3 Jul 8, 2024
11 checks passed
@Sebobo Sebobo deleted the bugfix/3781-fix-neos-ui-version-label branch July 8, 2024 12:35
mhsdesign added a commit that referenced this pull request Sep 19, 2024
Currently, it says:
> UI version: origin/8.3-dev

but it should be:
> UI version: 8.3-dev
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants