-
-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUGFIX: Use 12/24 hour format for DateTimePicker depending on configured format
#3737
BUGFIX: Use 12/24 hour format for DateTimePicker depending on configured format
#3737
Conversation
format
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Alvadda,
nice work! Deriving this from the configured format makes complete sense and I was able to test your change locally to verify that it works like a charm 👍
Just one minor nitpick on the code, that's all :)
Since this is being treated as BUGFIX
, the PR should target 8.3
rather than 8.4
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the adjustments, @Alvadda 👍
9836bf3
to
cf8afd3
Compare
Currently the DateTimePicker always uses the 12h time format even if the time format specified is in 24h format.
Currently supported hour formats from docs:
This change ensures that the 24h format is used for entering times when a 24h format was configured.
For testing:
Fixes partly : #3412