Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUGFIX: document-node is redirected to the nearest parent on workspace change #3734

Merged
merged 3 commits into from
May 14, 2024

Conversation

c4ll-m3-j4ck
Copy link
Contributor

Previously, on changing from a workspace to another one that didn't contain the current document-node, an exception would be triggered if no new document-node could be found a single level up in the node-tree.

This PR changes this behaviour to walk up the node-tree until a document-node can be found (going up to the site-node eventually) and sets the new document node to the first shared one that can be found in the rootline.

@github-actions github-actions bot added Bug Label to mark the change as bugfix 8.3 labels Mar 6, 2024
Copy link
Member

@Sebobo Sebobo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx

@mhsdesign
Copy link
Member

I could reproduce the bug

Wasn't able to locate any valid node in rootline of node /sites/neosdemo/features/navigation-elements/third-item/node-nh1g56sefvfkf/node-jwe1o0ggldihe@user-admin;language=en_US in the workspace live.

Scenario 1 is working currently:

  • create workspace
  • create new subpage in workspace and publish and highlight it
  • change workspace to live again

But scenario 2 fails currently:

  • create workspace
  • create new subpage in workspace
  • create new subsubpage in workspace
  • publish and highlight the new subsubpage
  • change workspace to live again

Copy link
Member

@mhsdesign mhsdesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cant say if this covers or breaks every edgecase but both scenario 1 and 2 are now working correctly (im redirected to the closest page that exists in the base ws)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.3 Bug Label to mark the change as bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants