-
-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUGFIX: Neos redirection issue in subfolder configuration #3713
Conversation
Addressing an issue where the redirection to /neos fails when Neos runs in a subfolder. This commit introduces a new route to the defaultModule. The index action of the backend controller is responsible for ensuring the correct backend module. Additionally, consideration for the preferredStartModules configuration has been incorporated here. Fixes: neos/neos-development-collection#4797
If this is ok, we can maybe also use it here in the neos-ui manifest
|
🎥 End-to-End Test Recordings These videos demonstrate the end-to-end tests for the changes in this pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested in project with subfolder configuration. Works like a charm. Thx for taking care 💖
We will have to make sure this is not lost during upmerges as of the changes in #3682. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes and using this in the other /neos
spot also makes absolutely sense.
Hmm, now the end-to-end tests are not working anymore 🙈 |
sorry :D |
Addressing an issue where the redirection to
/neos
fails when Neos runs in a subfolder. This commit introduces a new route to thedefaultModule
. The index action of the backend controller is responsible for ensuring the correct backend module. Additionally, consideration for thepreferredStartModules
configuration has been incorporated here.Fixes: neos/neos-development-collection#4797