TASK: Declare public api in php classes #3704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NONE. Nearly. But what is this? A small village ...
mhsdesign
changed the base branch from
9.0
to
feature/multi-app/01-foundation
mhsdesign
changed the title
mhsdesign
changed the title
mhsdesign
changed the base branch from
feature/multi-app/01-foundation
to
9.0
mhsdesign
commented
Feb 2, 2024
| @@ -17,6 +17,7 @@ | |||
| /** | |||
| * Contract for Node Creation handler that allow to hook into the process just before a node is being added | |||
| * via the Neos UI | |||
| * @api | |||
There was a problem hiding this comment.
to be transparent with you ;) that is the only php class/interface in the neos.ui which deserves an @api notation. Any objections? Or do you need another thing to be declared @api as well?
| @@ -22,6 +22,7 @@ | |||
|
|
|||
| /** | |||
| * The Workspace helper for EEL contexts | |||
| * @todo EEL helpers are still to be declared as internal | |||
There was a problem hiding this comment.
And why you did not declare it ;)
There was a problem hiding this comment.
because this would be to controversy to declare that in this pr. Will be discussed in a followup if the helper was actually useful in some obscure case.
markusguenther
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #3682 which must be merged first.
I recently had someone ask me how to use this
Propertything in Neos9. At first i was confused. And then i understood he was trying to use the Neos.Ui "change" classes.To avoid that in the future and make it also easier to clean up our php mess in the Neos UI ^^ i placed a few internal annotations around.
and the changes now explicitly warn from being used :D (which is spoiler really hard anyway ^^ - otherwise we would have tests *g)
If you happen to use any class from the Neos Ui previously (which should not be the case, as the ui has nothing to offer for php users ^^), which is not declared as api anymore, you should please prepare to refactor it.
What I did
How I did it
How to verify it