TASK: Avoid heavily use of controller context and make Neos.Ui.NodeInfo internal
#3703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhsdesign
added a commit
to mhsdesign/neos-development-collection
that referenced
this pull request
Jan 30, 2024
As that will be removed via neos/neos-ui#3703
6 tasks
mhsdesign
changed the title
Neos.Ui.NodeInfo internalNeos.Ui.NodeInfo internal
6 tasks
neos-bot
pushed a commit
to neos/neos
that referenced
this pull request
Jan 31, 2024
As that will be removed via neos/neos-ui#3703
mhsdesign
changed the base branch from
feature/multi-app/01-foundation
to
9.0
And declare the `NodeInfoHelper` as internal.
mhsdesign
force-pushed
the
task/avoidHeavilyUseOfControllerContext
branch
from
be33cbb to
ce7cd45
Compare
|
🎥 End-to-End Test Recordings These videos demonstrate the end-to-end tests for the changes in this pull request. |
mhsdesign
changed the title
Neos.Ui.NodeInfo internalNeos.Ui.NodeInfo internal
grebaldi
approved these changes
Feb 14, 2024
There was a problem hiding this comment.
Hi @mhsdesign,
nice work :) A left a tiny nitpicky comment, but the rest LGTM 👍
| @@ -30,6 +30,7 @@ | |||
| use Neos\Neos\Utility\NodeTypeWithFallbackProvider; | |||
|
|
|||
| /** | |||
| * @internal | |||
| * @Flow\Scope("singleton") | |||
| * @todo EEL helpers are still to be declared as internal | |||
There was a problem hiding this comment.
Suggested change
| * @todo EEL helpers are still to be declared as internal |
This should go, since NodeInfoHelper is marked @internal now in L33.
There was a problem hiding this comment.
a i forgot how i did it, but yes this pr is basically step one and later we followup with #3711 so ill merge it first ;)
Thanks for looking so deep into it :D
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If for some reason
Neos.Ui.NodeInfowas used in consumer fusion land it must be migrated.For migration please copy the parts of the
NodeInfohelper to your own helper.Note that the helper is sorely an internal detail of the user interface.
What I did
How I did it
How to verify it