Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUGFIX: Add ellipsis to nodeInfoView content #3700

Merged
merged 1 commit into from
Jan 30, 2024

Conversation

markusguenther
Copy link
Member

The NodeTypeName in the info panel was getting cut off, so I implemented a solution to enhance the display. Now, an ellipsis is added to prevent overflow within the container, and the full NodeType name is accessible through a tooltip that appears when hovered over.

Fixes: #3637

Screenshot 2024-01-26 at 12 38 07

The NodeTypeName in the info panel was getting cut off, so I implemented a solution to enhance the display. Now, an ellipsis is added to prevent overflow within the container, and the full NodeType name is accessible through a tooltip that appears when hovered over.

Fixes: neos#3637
@github-actions github-actions bot added Bug Label to mark the change as bugfix 9.0 labels Jan 26, 2024
@markusguenther markusguenther changed the base branch from 9.0 to 7.3 January 26, 2024 11:48
@github-actions github-actions bot added 7.3 and removed 9.0 labels Jan 26, 2024
@markusguenther
Copy link
Member Author

We can also think about an improvement to be able to get the NodeType name to the clipboard by an extra button or just clicking it. But that's more a feature then.

Copy link
Member

@mhsdesign mhsdesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, but seboo fixed it differently for 8.3 #3662

its still not perfect, but i wouldnt change legacy behavour.

@markusguenther
Copy link
Member Author

Thank you for your feedback. I appreciate your concern about the consistency of the solution across different branches. However, I would like to clarify that my PR does not introduce a behavior change, but rather a visual improvement. The text in the nodetype name info view was floating out of the container and looking broken, which was not a good user experience. My PR adds an ellipsis to indicate that there is more text available, and the popup with the full name was always there on hover. This is a common UI pattern that is used in many applications. I hope this explains my reasoning behind the PR. Please let me know if you have any questions or suggestions. The change from @Sebobo was not linked in the issue btw ;)

@Sebobo
Copy link
Member

Sebobo commented Jan 26, 2024

We just have to adjust the change during upmerge as this one will break the intention of my change

@mhsdesign mhsdesign dismissed their stale review January 26, 2024 22:55

Sorry for so boldly blocking this.

@mhsdesign
Copy link
Member

Thanks for your in depth elaboration. As it seems that seb is fine change as well I won’t be blocking this any further.
And I appreciate it a lot that you put so much love into the final 7.3 release. Please forgive my hard criticism for any last minute changes 😬^^

(and yes unfortunately sebs fix was not linked in my mentioned issue above. I’m sorry for that, as it caused additional effort on your end)

Copy link
Member

@Sebobo Sebobo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's fine for 7.3 and works as expected. But please make sure to verify the behaviour of my change in 8.3 when upmerging.

@markusguenther markusguenther merged commit b34d35b into neos:7.3 Jan 30, 2024
7 checks passed
@bwaidelich
Copy link
Member

Hi all,
I have noticed that node type names contain weird whitespace characters between the segments when copied from the NodeInfoView, e.g. Some.SHYPackage:SHYDocument.SHYFoo. Could this be related to this change, @markusguenther ?

@Sebobo
Copy link
Member

Sebobo commented Apr 10, 2024

@bwaidelich a fix of mine causes this, I know of a better solution now and will create a new PR soonish

@bwaidelich
Copy link
Member

@Sebobo ah, thx for the info. Could you share a link to the change with the "regression"?
I stumble upon this a lot, e.g. when filtering the db for nodes of a type because those whitespaces are not directly visible

@Sebobo
Copy link
Member

Sebobo commented Apr 10, 2024

@bwaidelich #3662
The improved solution just needs a <wbr> instead of the shy character, from my tests this then fulfils both readability and copy&paste requirements.

@bwaidelich
Copy link
Member

@Sebobo great, thanks for the info

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
7.3 Bug Label to mark the change as bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NodeTypeName is cut off in info panel
4 participants