-
-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUGFIX: Add ellipsis to nodeInfoView content #3700
Conversation
The NodeTypeName in the info panel was getting cut off, so I implemented a solution to enhance the display. Now, an ellipsis is added to prevent overflow within the container, and the full NodeType name is accessible through a tooltip that appears when hovered over. Fixes: neos#3637
We can also think about an improvement to be able to get the NodeType name to the clipboard by an extra button or just clicking it. But that's more a feature then. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, but seboo fixed it differently for 8.3 #3662
its still not perfect, but i wouldnt change legacy behavour.
Thank you for your feedback. I appreciate your concern about the consistency of the solution across different branches. However, I would like to clarify that my PR does not introduce a behavior change, but rather a visual improvement. The text in the nodetype name info view was floating out of the container and looking broken, which was not a good user experience. My PR adds an ellipsis to indicate that there is more text available, and the popup with the full name was always there on hover. This is a common UI pattern that is used in many applications. I hope this explains my reasoning behind the PR. Please let me know if you have any questions or suggestions. The change from @Sebobo was not linked in the issue btw ;) |
We just have to adjust the change during upmerge as this one will break the intention of my change |
Thanks for your in depth elaboration. As it seems that seb is fine change as well I won’t be blocking this any further. (and yes unfortunately sebs fix was not linked in my mentioned issue above. I’m sorry for that, as it caused additional effort on your end) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's fine for 7.3 and works as expected. But please make sure to verify the behaviour of my change in 8.3 when upmerging.
Hi all, |
@bwaidelich a fix of mine causes this, I know of a better solution now and will create a new PR soonish |
@Sebobo ah, thx for the info. Could you share a link to the change with the "regression"? |
@bwaidelich #3662 |
@Sebobo great, thanks for the info |
The NodeTypeName in the info panel was getting cut off, so I implemented a solution to enhance the display. Now, an ellipsis is added to prevent overflow within the container, and the full NodeType name is accessible through a tooltip that appears when hovered over.
Fixes: #3637