Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUGFIX: Allow float numbers in RangeEditor #3651

Merged
merged 4 commits into from
Nov 5, 2023
Merged

BUGFIX: Allow float numbers in RangeEditor #3651

merged 4 commits into from
Nov 5, 2023

Conversation

jonnitto
Copy link
Member

@jonnitto jonnitto commented Oct 23, 2023 •
edited
Loading

Fix #3650

Before

CleanShot.2023-10-23.at.12.05.28.mp4

After

CleanShot.2023-10-23.at.12.02.30.mp4

@github-actions github-actions bot added Bug Label to mark the change as bugfix 7.3 labels Oct 23, 2023
@jonnitto jonnitto self-assigned this Oct 23, 2023
@jonnitto jonnitto changed the title BUGFIX: Allow float numbers as steps in RangeEditor BUGFIX: Allow float numbers in RangeEditor Oct 23, 2023
@jonnitto jonnitto linked an issue Oct 23, 2023 that may be closed by this pull request
Range editor doesn't support steps below 1 #3650
Closed
@jonnitto jonnitto marked this pull request as draft October 23, 2023 11:02
@jonnitto jonnitto marked this pull request as ready for review October 23, 2023 11:29
@jonnitto
Copy link
Member Author

Basically, we should also add a debounce function to the <input type="text" /> for the direct input. But this is another topic

mhsdesign
mhsdesign approved these changes Nov 5, 2023
View reviewed changes
Copy link
Member

@mhsdesign mhsdesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At some point we should probably also consider the type (int vs float) here and depending on this limit step to a natural number, but i think for now this is a good fix

@jonnitto jonnitto merged commit 35e5c51 into 7.3 Nov 5, 2023
9 checks passed
@jonnitto jonnitto deleted the bugfix/rangeeditor_with_float_values branch November 5, 2023 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhsdesign mhsdesign mhsdesign approved these changes

@grebaldi grebaldi Awaiting requested review from grebaldi

Assignees

@jonnitto jonnitto

Labels
7.3 Bug Label to mark the change as bugfix next-patch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Range editor doesn't support steps below 1
2 participants
@jonnitto @mhsdesign