BUGFIX: Render RightSideBar components even if the sidebar is hidden

[grebaldi]

fixes: #1744

The problem

Peek.2023-06-24.09-53.1744.before.mp4

In #1744 @maltemuth figured out that the rendering of the RightSideBarComponents is prevented in case the side bar is hidden.

Since the <Tabs/> component from @neos-project/react-ui-components is responsible for tracking the open-tab-state, removing the component from the rendering tree inevitably leads to a reset of that state.

The solution

Peek.2023-06-24.09-50.1744.after.mp4

I removed the condition, so that the RightSideBarComponents are now rendered regardless of the toggle-state of the side bar.

Since this is technically a removal of code that was intended to be a performance optimization, I should probably address the potential performance impact:

I believe the idea was to save on the creation of React elements in case they're not actually visible to the user. While this sounds intuitively plausible, I would theorize that this actually hurts performance. Preventing the React elements from being created will cause ReactDOM to remove the DOM tree represented by those elements. When the side bar becomes visible again, the React elements will again be created, which leads ReactDOM to create an entirely new DOM tree from those elements.

If the creation of the React elements isn't prevented, ReactDOM probably won't do anything at all. It would therefore be a fair assumption that this change will lead to a slight performance improvement :)

[crydotsnake]

Fine by reading

[mhsdesign]

Thanks for addressing my unasked question about the performance aspect. You can read my mind.