-
-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEATURE: Remove 1K Dependencies & and separat webpack adapter extensibility package #3382
Conversation
…ntials replacement
…d remove `build-essentials`
380def9
to
eefb66d
Compare
7b7348d
to
890b4d3
Compare
…uildExtensibility-backup
5cf890a
to
7b7348d
Compare
Ready to review. Left over todos and discussions about the naming of the package Todos for next time:
require("esbuild").build({
logLevel: "info",
bundle: true,
target: "es2020",
entryPoints: {"Plugin": "src/index.js"},
loader: {
".js": "tsx",
},
alias: require("@neos-project/neos-ui-extensibility/extensibilityMap.json"),
outdir: "../../Public/NeosUserInterface",
})
|
i discussed the naming of |
I just released a |
7cf06c0
to
e502b36
Compare
e502b36
to
15993f9
Compare
# Conflicts: # packages/babel-preset-neos-ui/src/index.js # packages/build-essentials/package.json # packages/neos-ui-backend-connector/package.json # packages/neos-ui-constants/package.json # packages/neos-ui-contentrepository/package.json # packages/neos-ui-decorators/package.json # packages/neos-ui-editors/package.json # packages/neos-ui-extensibility/package.json # packages/neos-ui-guest-frame/package.json # packages/neos-ui-i18n/package.json # packages/neos-ui-inspector/package.json # packages/neos-ui-redux-store/package.json # packages/neos-ui-sagas/package.json # packages/neos-ui-validators/package.json # packages/neos-ui-views/package.json # packages/neos-ui/package.json # packages/positional-array-sorter/package.json # packages/react-proptypes/package.json # packages/utils-helpers/package.json # packages/utils-logger/package.json # packages/utils-redux/package.json # yarn.lock
It looks good to me and I like the Again a remarkable but not so handsome PR ;) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💥
TASK: Reresolve merge conflicts of #3382
i started cleaning up more than initially thought with #3366 so this pr is made ontop on it ;)
solves: #3215
What i did:
@neos-project/neos-ui-extensibility
a code only repo (eg no webpack, only the extensibilityMap.json and the shim js files)@neos-project/neos-ui-extensibility
and@neos-project/build-essentials
into@neos-project/neos-ui-extensibility-webpack-adapter
@neos-project/babel-preset-neos-ui
(was forgotten)@neos-project/neos-ui-build
for all the esbuild specific plugins and other build scripts (this package will not be released)@neos-project/neos-ui-extensibility-webpack-legacy
installed in the workspace but not its dependencies (we dont need webpack and babel anymore)clean
command from each packagegpristine
is your friend ;)Todos:
yarn dedupe '@babel/*'
yarn dedupe prop-types