BUGFIX: Fix error msg of CountValidator #3376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlubitz
requested changes
Feb 16, 2023
dlubitz
approved these changes
Feb 16, 2023
|
Is 8.3 the right target branch? |
|
It seems to be a regression introduced with 8.0 in #2996. |
Should I rebase to 8.0? |
If you rebase your branch on a older history you would transfer all changes since the 8.0 release and not just this one. It will be easier if you start a new branch based on 8.0 and cherry pick your changes. |
Yeah I know, but for me I still call it 'rebasing', sry 😄 |
JamesAlias
force-pushed
the
bugfix-count-validator-error-msg-missing-min-max
branch
from
1c6379f to
34d2a08
Compare
ahaeslich
approved these changes
Feb 16, 2023
ahaeslich
deleted the
bugfix-count-validator-error-msg-missing-min-max
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Fixed issue 4034 in Neos Repo.
How I did it
Fixed regression.
Wrote a unit test that checks that the validation function returns an React element with the correct props in case of an error.
How to verify it
Run tests.