BUGFIX: Distribute height between inspector tabs header and content dynamically #3338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markusguenther
approved these changes
Jan 19, 2023
crydotsnake
approved these changes
Jan 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #2683
The Problem
The
<Inspector/>-styles allocate height between the tabs header and the tabs content based on the assumption that there's only one tab header row. As soon as the tabs header breaks into a second row, the tabs content underflows the action buttons at the bottom of the<Inspector/>component.The Solution
I've adjusted the
<Inspector/>-styles usingdisplay: flexto distribute the height between the tabs header and the tabs content dynamically. This way, all of the tabs contents remain reachable, even if the tabs header breaks into a third row:Peek.2023-01-18.16-15.-.Inspector.spacing.webm