BUGFIX: Hide inline toolbar if current editPreviewMode is not an edit mode #3334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crydotsnake
approved these changes
Jan 16, 2023
markusguenther
approved these changes
Jan 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #3144
The Problem
The
<ContentCanvas/>did not distinguish between edit- and preview-modes when rendering the<InlineUI/>component.This lead to the
<InlineUI/>still being present, even though a preview-mode (like "desktop") had been selected.The Solution
I added a condition to the
rendermethod of the<ContentCanvas/>component. If the currently selectededitPreviewModeis not an edit-mode, the<InlineUI/>component will not be rendered any longer.