BUGFIX: Make sure secondary inspector container does not overlap editors in node creation dialog #3324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ors in node creation dialog fixes: neos#3318
Sebobo
approved these changes
Jan 11, 2023
|
Thx! |
crydotsnake
approved these changes
Jan 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #3318
The Problem
This is a regression through #2870.
The secondary inspector for the node creation dialog is wrapped in a container that is invisible, but has a padding that overlaps part of the editors.
In cases in which the help message button flows into the next row, the button is entirely covered by that padding and can therefore not be clicked.
The Solution
Quite simple: I added
overflow: hidden;to the surrounding container, so the padding cannot overlap the editors anymore:Peek.2023-01-05.10-28.-.RichTextEditor.Help.Message.mp4