BUGFIX: Make sure that validation errors show up after clicking "Create New" in node creation dialog #3323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…te New" in node creation dialog fixes: neos#3319
Sebobo
approved these changes
Jan 11, 2023
crydotsnake
approved these changes
Jan 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #3319
Turns out this could be achieved by simply setting the creation dialog's
isDirtystate totruewhen validation errors occur duringhandleApply.On a side note, this made me wonder why there is an
isDirtystate for the creation dialog in the first place. It makes sense that the editor fields only show validation errors once they've been touched, but that is their concern. When "Create New" was clicked, all validation errors should show in any case.