Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: Regression node info table layout broken #3480

Closed
mhsdesign opened this issue May 2, 2023 · 4 comments
Closed

BUG: Regression node info table layout broken #3480

mhsdesign opened this issue May 2, 2023 · 4 comments
Assignees
@Sebobo
Labels
8.2 9.0 Bug Label to mark the change as bugfix Good first issue UI & UX

Comments

@mhsdesign
Copy link
Member

8.0
image

8.3
image
@grebaldi
Copy link
Contributor

grebaldi commented May 3, 2023

I think this should actually be a description list (<dl/>) rather than a table: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/dl

@grebaldi grebaldi added Bug Label to mark the change as bugfix UI & UX 8.3 Good first issue labels May 3, 2023
@grebaldi
Copy link
Contributor

grebaldi commented May 3, 2023

This seems to occur on 8.2 as well: https://neos-project.slack.com/archives/C0U0KEGDQ/p1683116589047559

@ahaeslich ahaeslich mentioned this issue May 3, 2023
Merged
@ahaeslich ahaeslich added 8.2 and removed 8.3 labels May 3, 2023
@ahaeslich
Copy link
Member

I think this should actually be a description list (<dl/>) rather than a table: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/dl

Yes, this would be way better. Actually it currently is a <ul/>. As seen in this change: #3478.

@Sebobo Sebobo self-assigned this May 5, 2023
Sebobo added a commit that referenced this issue May 5, 2023
@Sebobo
BUGFIX: InfoTableLayout style broken
b2785cb 
Resolves: #3480
@Sebobo Sebobo mentioned this issue May 5, 2023
Merged
@Sebobo
Copy link
Member

Sebobo commented May 5, 2023

Let's refactor the markup for 9.0, I fixed the style issue in #3484

@ahaeslich ahaeslich added the 9.0 label May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Sebobo Sebobo

Labels
8.2 9.0 Bug Label to mark the change as bugfix Good first issue UI & UX
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@Sebobo @ahaeslich @grebaldi @crydotsnake @mhsdesign