Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TASK: Improve ckeditor plugin migration to Neos 8.2 and up #3452

Closed
mhsdesign opened this issue Mar 30, 2023 · 2 comments · Fixed by #3454
Closed

TASK: Improve ckeditor plugin migration to Neos 8.2 and up #3452

mhsdesign opened this issue Mar 30, 2023 · 2 comments · Fixed by #3454

Comments

@mhsdesign
Copy link
Member

mhsdesign commented Mar 30, 2023

Description

currently an unreadable error is thrown which doesnt directly mention that it is a ckeditor plugin wich causes the error.
there are no upgrade instructions at: https://docs.neos.io/api/upgrade-instructions/8/upgrade-instructions-8-1-8-2

edit: there are actually instructions but i find them hard to understand 😂

related: #3287

[Description of the bug or feature]

Steps to Reproduce

  1. [First Step]
  2. [Second Step]
  3. [and so on...]

Expected behavior

[What you expected to happen]

Actual behavior

[What actually happened]

Affected Versions

Neos:

UI:

You can get this information by running composer show or using the package management module within Neos.
The UI version can also be found inside the left sidebar after version 1.0.3.

@mhsdesign
Copy link
Member Author

i think @mficzel and @ahaeslich can tell a song about how long it took them to find out that a ckeditor plugin in the neos.demo caused the odd console errors :/

@mhsdesign
Copy link
Member Author

haha just found this message burried in the 8.2 blog post (hidden)

!!! A temporary breaking change!!!

Due to the update of our build environment, old Neos UI plugins that extend classes which are provided by the Neos core might throw errors due to an incompatibility. The extensibility package still converts JS classes to functions, and the browser throws an error if those try to extend an existing actual "class".

We are currently working on a solution for this, which should arrive in one of the next patch releases. There are of course other ways to make your plugin compatible already, without waiting for a patch. One is to convert the classes that extend core classes to functions instead.

We always try to prevent breaking changes in a minor release, sadly we saw this issue too late, as only some plugins are affected, and we cannot simply roll back the changes that lead to this issue.TODO: Provide link to tutorial

markusguenther added a commit that referenced this issue Apr 25, 2023
TASK: Improve ckeditor plugin migration to Neos 8.2 and up #3452
@github-project-automation github-project-automation bot moved this from Review Required 👀 to Done ✅ in Neos & Flow 8.3 Release Board Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

1 participant