Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What to do with storybook? #3268

Open
mhsdesign opened this issue Nov 24, 2022 · 6 comments
Open

What to do with storybook? #3268

mhsdesign opened this issue Nov 24, 2022 · 6 comments

Comments

@mhsdesign
Copy link
Member

mhsdesign commented Nov 24, 2022

A: Totally abandon and remove it
B: start reusing it again (partly) is totally broken for now because of #3200
C: using alternatives #3268 (comment)

@mhsdesign
Copy link
Member Author

@JamesAlias

storybook relies on own webpack config -> currently broken. Does anyone use storybook right now?

@markusguenther

Not sure, but the storybook is outdated, and I bet that no one uses that anymore. So maybe we can save some time and disable or remove the storybook. I did not use it for years now, can remember the sprint 2018 in Vienna... at some point it broke.

@grebaldi
Copy link
Contributor

As of today, there are plenty of alternatives for storybook:

I would favor a solution that allows us to do reliable visual regression tests. The best (FOSS-)tool I know to achieve the latter is BackstopJS (https://github.com/garris/BackstopJS). It is not coupled to any particular styleguide, so anything lightweight (and preferably low on dependencies) will be good.

However, as a first step I would argue in favor of A, because our storybook integration has actually no benefit atm.

As a side note:
Likewise, I'd like to suggest to drop @friendsofreactjs/react-css-themr. AFAIR there were plans for having something akin to a "light theme" for the UI, but neither were those plans ever realized nor does @friendsofreactjs/react-css-themr seem to actually enable this (though, I'm not entirely sure about that).

@mhsdesign
Copy link
Member Author

The only current upside i see in story book is to have a guideline how to composit more complex components (like a dragable tree item) - but then again even these stories are mostly outdated and always reachable via gits history

@mhsdesign
Copy link
Member Author

With my latest cleanups i completely removed any left over storybook dependencies and configs.
The only that is left are the stories, as they can be helpfull to know how to use a component (fx. if the tests dont test it ... (especially more complex things like the node tree))

@grebaldi
Copy link
Contributor

grebaldi commented May 1, 2023

Can this be closed, @mhsdesign?

@grebaldi grebaldi added the needs verification A question concerning a possible solution needs an answer from the issue's author. label May 1, 2023
@mhsdesign
Copy link
Member Author

As long as we still have the .story.js lying around lets keep it open

@grebaldi grebaldi added Cleanup Reminder Technical debt and removed needs verification A question concerning a possible solution needs an answer from the issue's author. labels May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

No branches or pull requests

2 participants