TASK: Fix linting issues

Autofix via eslint

packages/neos-ts-interfaces/src/index.ts

@@ -13,7 +13,6 @@ export interface DimensionCombination {
     [propName: string]: DimensionValues;
 }
 
-
 export interface DimensionPresetCombination {
     [propName: string]: DimensionPresetName;
 }

packages/neos-ui-backend-connector/src/Endpoints/index.ts

@@ -279,7 +279,6 @@ export default (routes: Routes) => {
             assetProxyTable.innerHTML = result;
             const assetProxies = Array.from(assetProxyTable.querySelectorAll('.asset-proxy')) as HTMLElement[];
 
-
             const mappedAssetProxies = assetProxies.map((assetProxy: HTMLElement) => {
                 const assetSourceIdentifier = getElementInnerText(assetProxy, '.asset-source-identifier');
                 const assetSourceLabel = getElementInnerText(assetProxy, '.asset-source-label');
@@ -650,7 +649,7 @@ export default (routes: Routes) => {
             },
             body: JSON.stringify({
                 contextNode: nodeContextPath,
-                text,
+                text
             })
         }))
             .then(response => fetchWithErrorHandling.parseJson(response))

packages/neos-ui-backend-connector/src/index.ts

@@ -41,7 +41,6 @@ export const initializeJsAPI = (parent: {[propName: string]: any}, {alias = 'neo
     return parent[alias];
 };
 
-
 //
 // Expose methods to access the initialized api
 //

packages/neos-ui-contentrepository/src/registry/NodeTypesRegistry.ts

@@ -41,7 +41,7 @@ interface ViewConfiguration {
     [prop: string]: any;
 }
 // We have to use a custom type guard in order to filter out null values, see https://codereview.stackexchange.com/a/184004
-const isGroupedNodeTypeListItem = (str: GroupedNodeTypeListItem | null): str is GroupedNodeTypeListItem => !!str;
+const isGroupedNodeTypeListItem = (str: GroupedNodeTypeListItem | null): str is GroupedNodeTypeListItem => Boolean(str);
 
 export default class NodeTypesRegistry extends SynchronousRegistry<NodeType> {
     private _constraints: ConstraintsMap = {};
@@ -56,7 +56,7 @@ export default class NodeTypesRegistry extends SynchronousRegistry<NodeType> {
 
     private _inspectorViewConfigurationCache: {[propName: string]: any} = {};
 
-    public setConstraints (constraints: ConstraintsMap): void {
+    public setConstraints(constraints: ConstraintsMap): void {
         this._constraints = constraints;
     }
 
@@ -80,9 +80,8 @@ export default class NodeTypesRegistry extends SynchronousRegistry<NodeType> {
         const role = this.getRole(roleName);
         if (role) {
             return this.isOfType(nodeTypeName, role);
-        } else {
-            return false;
         }
+        return false;
     }
 
     public getAllowedChildNodeTypes(nodeTypeName: string): NodeTypeName[] {
@@ -201,9 +200,9 @@ export default class NodeTypesRegistry extends SynchronousRegistry<NodeType> {
 
                     return isMatch || isDefaultTab;
                 }).map(group => ({
-                        ...group,
-                        items: positionalArraySorter([
-                            ...properties.filter(p => $get(['ui', 'inspector', 'group'], p) === group.id)
+                    ...group,
+                    items: positionalArraySorter([
+                        ...properties.filter(p => $get(['ui', 'inspector', 'group'], p) === group.id)
                                 .map(property => ({
                                     type: 'editor',
                                     id: $get(['id'], property),
@@ -216,7 +215,7 @@ export default class NodeTypesRegistry extends SynchronousRegistry<NodeType> {
                                     helpThumbnail: $get(['ui', 'help', 'thumbnail'], property)
                                 })
                             ),
-                            ...views.filter(v => $get(['group'], v) === group.id)
+                        ...views.filter(v => $get(['group'], v) === group.id)
                                 .map(property => ({
                                     type: 'view',
                                     id: $get(['id'], property),
@@ -227,8 +226,8 @@ export default class NodeTypesRegistry extends SynchronousRegistry<NodeType> {
                                     helpMessage: $get(['helpMessage'], property)
                                 })
                             )
-                        ], 'position', 'id')
-                    })
+                    ], 'position', 'id')
+                })
                 )
             }))
         };

packages/neos-ui-decorators/src/neos.tsx

@@ -21,7 +21,6 @@ export const NeosContext = React.createContext<NeosContextInterface | null>(null
 // configuration
 export default <OwnProps extends {}, InjectedProps extends {}> (mapRegistriesToProps: (globalRegistry: GlobalRegistry) => any) => (WrappedComponent: React.ComponentType<OwnProps & InjectedProps>) => {
     const Decorator = class NeosDecorator extends React.PureComponent<OwnProps> {
-
         public static readonly Original = WrappedComponent;
 
         public static readonly contextType = NeosContext;

packages/neos-ui-editors/src/SecondaryEditors/CodeMirrorWrap/index.js

@@ -3,7 +3,7 @@ import PropTypes from 'prop-types';
 import {UnControlled as CodeMirror} from 'react-codemirror2';
 
 // TODO: Find way to dynamically load any mode?
-/* eslint-disable no-unused-vars */
+/* eslint-disable @typescript-eslint/no-unused-vars */
 import XmlMode from 'codemirror/mode/xml/xml';
 import HtmlMixedMode from 'codemirror/mode/htmlmixed/htmlmixed';
 import JavascriptMode from 'codemirror/mode/javascript/javascript';
@@ -12,7 +12,7 @@ import MarkdownMode from 'codemirror/mode/markdown/markdown';
 import YamlMode from 'codemirror/mode/yaml/yaml';
 import Styles from './codemirror.vanilla-css';
 import ThemeStyles from './codemirror-twilight.vanilla-css';
-/* eslint-enable no-unused-vars */
+/* eslint-enable @typescript-eslint/no-unused-vars */
 
 export default class CodeMirrorWrap extends PureComponent {
     static propTypes = {

packages/neos-ui-editors/src/SecondaryEditors/ImageCropper/index.js

@@ -11,7 +11,7 @@ import AspectRatioDropDown from './AspectRatioDropDown/index';
 import CropConfiguration, {CustomAspectRatioOption, LockedAspectRatioStrategy} from './model.js';
 import style from './style.css';
 
-/* eslint-disable no-unused-vars */
+/* eslint-disable @typescript-eslint/no-unused-vars */
 import ReactCropStyles from './react_crop.vanilla-css';
 /* eslint-enable no-unused-vars */
 import {$get} from 'plow-js';

packages/neos-ui-extensibility/src/readFromConsumerApi.ts

@@ -4,6 +4,6 @@ export default function readFromConsumerApi(key: string): (...args: any[]) => an
             return (window as any)['@Neos:HostPluginAPI'][`@${key}`](...args);
         }
 
-        throw new Error("You are trying to read from a consumer api that hasn't been initialized yet!");
+        throw new Error('You are trying to read from a consumer api that hasn\'t been initialized yet!');
     };
 }

packages/neos-ui-extensibility/src/registry/AbstractRegistry.ts

@@ -1,5 +1,6 @@
 export default class AbstractRegistry {
     public SERIAL_VERSION_UID = 'd8a5aa78-978e-11e6-ae22-56b6b6499611';
+
     public description: string;
 
     constructor(description: string) {

packages/neos-ui-redux-store/src/CR/ContentDimensions/index.ts

@@ -52,7 +52,7 @@ export const actions = {
     /**
      * Sets the currently allowed presets for dimension
      */
-    setAllowed: (dimensionName: string, allowedPresets: DimensionPresetName[]) => createAction(actionTypes.SET_ALLOWED,  {dimensionName, allowedPresets})
+    setAllowed: (dimensionName: string, allowedPresets: DimensionPresetName[]) => createAction(actionTypes.SET_ALLOWED, {dimensionName, allowedPresets})
 };
 
 //
@@ -67,7 +67,7 @@ export const reducer = (state: State = defaultState, action: InitAction | Action
             break;
         }
         case actionTypes.SELECT_PRESET: {
-            const targetPresets = action.payload.targetPresets;
+            const {targetPresets} = action.payload;
             Object.keys(targetPresets).forEach(dimensionName => {
                 const presetName = targetPresets[dimensionName];
                 const dimensionValues = state.byName[dimensionName].presets[presetName].values;
@@ -78,7 +78,7 @@ export const reducer = (state: State = defaultState, action: InitAction | Action
             break;
         }
         case actionTypes.SET_ACTIVE: {
-            const dimensionValues = action.payload.dimensionValues;
+            const {dimensionValues} = action.payload;
             const previousActive = state.active;
             if (previousActive !== null) {
                 Object.keys(previousActive).forEach(dimensionName => {
@@ -165,7 +165,7 @@ const activePresetsSelector = createSelector([
     if (active !== null) {
         return mapValues(active, (dimensionValues, name) => {
             const dimensionConfiguration = byName[name];
-            const presets = dimensionConfiguration.presets;
+            const {presets} = dimensionConfiguration;
             const activePreset = Object.keys(presets).find(dimensionName => isEqual(presets[dimensionName].values, dimensionValues));
             const presetName = activePreset || dimensionConfiguration.defaultPreset;
             const finalActivePreset = presets[presetName];

packages/neos-ui-redux-store/src/CR/Nodes/helpers.ts

@@ -61,7 +61,8 @@ export const getNodeOrThrow = (nodeMap: NodeMap, contextPath: NodeContextPath) =
 export const calculateNewFocusedNodes = (selectionMode: SelectionModeTypes, contextPath: NodeContextPath, focusedNodesContextPaths: NodeContextPath[], nodesByContextPath: NodeMap): NodeContextPath[] | null => {
     if (selectionMode === SelectionModeTypes.SINGLE_SELECT) {
         return [contextPath];
-    } else if (selectionMode === SelectionModeTypes.RANGE_SELECT) {
+    }
+    if (selectionMode === SelectionModeTypes.RANGE_SELECT) {
         const lastSelectedNodeContextPath = focusedNodesContextPaths[focusedNodesContextPaths.length - 1];
         const lastSelectedNode = nodesByContextPath[lastSelectedNodeContextPath];
         if (lastSelectedNode && lastSelectedNode.parent) {
@@ -74,9 +75,8 @@ export const calculateNewFocusedNodes = (selectionMode: SelectionModeTypes, cont
                     if (startSelectionFlag) { // if matches for the second time it means that both start and end of selection were found
                         tempSelection.push(child.contextPath); // also push the last node
                         return true;
-                    } else {
-                        startSelectionFlag = true;
                     }
+                    startSelectionFlag = true;
                 }
                 if (startSelectionFlag) {
                     tempSelection.push(child.contextPath);

packages/neos-ui-redux-store/src/CR/Nodes/index.ts

@@ -496,8 +496,8 @@ export const reducer = (state: State = defaultState, action: InitAction | Action
             // Update the context path for stored descendant of the moved node including the node itself
             Object.keys(draft.byContextPath).forEach(contextPath => {
                 // Skip nodes that don't match the old path exactly or a descendant path
-                if (!contextPath.startsWith(oldPath + '/')
-                    && contextPath.split('@')[0] !== oldPath) {
+                if (!contextPath.startsWith(oldPath + '/') &&
+                    contextPath.split('@')[0] !== oldPath) {
                     return;
                 }
 
@@ -518,7 +518,7 @@ export const reducer = (state: State = defaultState, action: InitAction | Action
                     child.contextPath = child.contextPath.replace(oldPath, newPath);
                 });
 
-                delete Object.assign(draft.byContextPath, {[updatedContextPath]: node })[contextPath];
+                delete Object.assign(draft.byContextPath, {[updatedContextPath]: node})[contextPath];
             });
             break;
         }

packages/neos-ui-redux-store/src/CR/Nodes/selectors.ts

@@ -12,9 +12,9 @@ export const focusedNodePathsSelector = (state: GlobalState) => $get(['cr', 'nod
 // This is internal, as in most cases you want `focusedNodePathSelector`, which is able to fallback to documentNode, when no node is focused
 export const _focusedNodeContextPathSelector = createSelector(
     [
-        focusedNodePathsSelector,
+        focusedNodePathsSelector
     ],
-    (focusedNodePaths) => {
+    focusedNodePaths => {
         return focusedNodePaths && focusedNodePaths[0] ? focusedNodePaths[0] : null;
     }
 );
@@ -289,7 +289,6 @@ export const makeGetAllowedChildNodeTypesSelector = (nodeTypesRegistry: NodeType
 export const makeGetAllowedSiblingNodeTypesSelector = (nodeTypesRegistry: NodeTypesRegistry) =>
     makeGetAllowedChildNodeTypesSelector(nodeTypesRegistry, (nodeContextPath, state) => getPathInNode(state, nodeContextPath, 'parent'));
 
-
 export const makeIsAllowedToAddChildOrSiblingNodes = (nodeTypesRegistry: NodeTypesRegistry) => createSelector(
     [
         makeGetAllowedChildNodeTypesSelector(nodeTypesRegistry),
@@ -408,7 +407,7 @@ export const focusedNodeParentLineSelector = createSelector(
         let currentNode = focusedNode;
 
         while (currentNode) {
-            const parent = currentNode.parent;
+            const {parent} = currentNode;
             if (parent) {
                 currentNode = nodesByContextPath[parent] || null;
                 if (currentNode) {

packages/neos-ui-redux-store/src/CR/Workspaces/index.ts

@@ -68,7 +68,7 @@ const abortDiscard = () => createAction(actionTypes.DISCARD_ABORTED);
 /**
  * Confirm the ongoing discard
  */
-const confirmDiscard = () =>  createAction(actionTypes.DISCARD_CONFIRMED);
+const confirmDiscard = () => createAction(actionTypes.DISCARD_CONFIRMED);
 
 /**
  * Change base workspace

packages/neos-ui-redux-store/src/CR/Workspaces/selectors.ts

@@ -4,8 +4,6 @@ import {documentNodeContextPathSelector} from '../Nodes/selectors';
 import {GlobalState} from '../../System';
 import {NodeContextPath} from '@neos-project/neos-ts-interfaces';
 
-
-
 export const personalWorkspaceNameSelector = (state: GlobalState) => $get(['cr', 'workspaces', 'personalWorkspace', 'name'], state);
 
 export const baseWorkspaceSelector = (state: GlobalState) => $get(['cr', 'workspaces', 'personalWorkspace', 'baseWorkspace'], state);

packages/neos-ui-redux-store/src/CR/index.ts

@@ -1,6 +1,5 @@
 import {combineReducers} from '../combineReducers';
 
-
 import * as ContentDimensions from './ContentDimensions';
 import * as Nodes from './Nodes';
 import * as Workspaces from './Workspaces';

packages/neos-ui-redux-store/src/ServerFeedback/index.ts

@@ -2,7 +2,6 @@ import {action as createAction, ActionType} from 'typesafe-actions';
 
 // import {handleActions} from '@neos-project/utils-redux';
 
-
 //
 // Export the action types
 //

packages/neos-ui-redux-store/src/UI/AddNodeModal/index.ts

@@ -33,7 +33,7 @@ export enum actionTypes {
  * @param {Object} fusionPath (optional) fusion path of the rendered node relative to which the new node ought to be
  *                            positioned.
  */
-const open = (contextPath: NodeContextPath, fusionPath: FusionPath = '') =>  createAction(actionTypes.OPEN, {contextPath, fusionPath});
+const open = (contextPath: NodeContextPath, fusionPath: FusionPath = '') => createAction(actionTypes.OPEN, {contextPath, fusionPath});
 
 /**
  * Closes the add node modal.

packages/neos-ui-redux-store/src/UI/ContentCanvas/index.ts

@@ -53,8 +53,8 @@ export enum actionTypes {
     TOGGLE_LINK_EDITOR = '@neos/neos-ui/UI/ContentCanvas/TOGGLE_LINK_EDITOR'
 }
 
-const setPreviewUrl = (previewUrl: string) =>  createAction(actionTypes.SET_PREVIEW_URL, previewUrl);
-const setSrc = (src: string, metaKeyPressed: boolean = false) =>  createAction(actionTypes.SET_SRC, {src, metaKeyPressed});
+const setPreviewUrl = (previewUrl: string) => createAction(actionTypes.SET_PREVIEW_URL, previewUrl);
+const setSrc = (src: string, metaKeyPressed: boolean = false) => createAction(actionTypes.SET_SRC, {src, metaKeyPressed});
 const setFormattingUnderCursor = (formatting: Formatting) => createAction(actionTypes.FORMATTING_UNDER_CURSOR, formatting);
 const setCurrentlyEditedPropertyName = (propertyName: string) => createAction(actionTypes.SET_CURRENTLY_EDITED_PROPERTY_NAME, propertyName);
 const startLoading = () => createAction(actionTypes.START_LOADING);

packages/neos-ui-redux-store/src/UI/ContentTree/index.ts

@@ -37,7 +37,7 @@ const toggle = (contextPath: NodeContextPath) => createAction(actionTypes.TOGGLE
 const startLoading = () => createAction(actionTypes.START_LOADING);
 const stopLoading = () => createAction(actionTypes.STOP_LOADING);
 const reloadTree = () => createAction(actionTypes.RELOAD_TREE);
-const requestChildren = (contextPath: NodeContextPath, {unCollapse = true, activate = false} = {}) =>  createAction(actionTypes.REQUEST_CHILDREN, {contextPath, opts: {unCollapse, activate}});
+const requestChildren = (contextPath: NodeContextPath, {unCollapse = true, activate = false} = {}) => createAction(actionTypes.REQUEST_CHILDREN, {contextPath, opts: {unCollapse, activate}});
 const setAsLoading = (contextPath: NodeContextPath) => createAction(actionTypes.SET_AS_LOADING, {contextPath});
 const setAsLoaded = (contextPath: NodeContextPath) => createAction(actionTypes.SET_AS_LOADED, {contextPath});
 
@@ -79,13 +79,13 @@ export const reducer = (state: State = defaultState, action: InitAction | Action
             break;
         }
         case actionTypes.SET_AS_LOADING: {
-            const contextPath = action.payload.contextPath;
+            const {contextPath} = action.payload;
             draft.errors = draft.errors.filter(i => i !== contextPath);
             draft.loading.push(contextPath);
             break;
         }
         case actionTypes.SET_AS_LOADED: {
-            const contextPath = action.payload.contextPath;
+            const {contextPath} = action.payload;
             draft.loading = draft.loading.filter(i => i !== contextPath);
             break;
         }

packages/neos-ui-redux-store/src/UI/Inspector/index.ts

@@ -22,7 +22,6 @@ export const defaultState: State = {
     valuesByNodePath: {}
 };
 
-
 //
 // Export the action types
 //

packages/neos-ui-redux-store/src/UI/KeyboardShortcutModal/index.ts

@@ -11,7 +11,6 @@ export const defaultState: State = {
     isOpen: false
 };
 
-
 //
 // Export the action types
 //

packages/neos-ui-redux-store/src/UI/LeftSideBar/index.ts

@@ -9,7 +9,7 @@ export interface State extends Readonly<{
     contentTree: {
         isHidden: boolean;
     },
-    searchBar:  {
+    searchBar: {
         isVisible: boolean;
     };
 }> {}
@@ -24,8 +24,6 @@ export const defaultState: State = {
     }
 };
 
-
-
 //
 // Export the action types
 //

packages/neos-ui-redux-store/src/UI/NodeVariantCreationDialog/index.ts

@@ -69,5 +69,5 @@ export const reducer = (state: State = defaultState, action: InitAction | Action
 
 export const selectors = {
     isOpen: (state: GlobalState) => $get(['ui', 'nodeVariantCreationDialog', 'isOpen'], state),
-    numberOfParentNodesToBeCreated: (state: GlobalState) => $get(['ui', 'nodeVariantCreationDialog', 'numberOfParentNodesToBeCreated'], state),
+    numberOfParentNodesToBeCreated: (state: GlobalState) => $get(['ui', 'nodeVariantCreationDialog', 'numberOfParentNodesToBeCreated'], state)
 };