This repository has been archived by the owner on Feb 28, 2024. It is now read-only.
Various Logging Fixes #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljoonal
previously approved these changes
Mar 11, 2023
NeosModLoader/NeosVersionReset.cs
Outdated
Comment on lines
74
to
78
| if (Logger.IsDebugEnabled()) | ||
| { | ||
| string actualPlugins = plugins.Keys.Join(delimiter: ", "); | ||
| Logger.DebugInternal($"Found {plugins.Count} actual plugins: {actualPlugins}"); | ||
| } |
There was a problem hiding this comment.
Huumh, didn't we have debug methods just take in a closure that returns the debug string, and only gets called if the debug level is enabled...?
There was a problem hiding this comment.
Actually... that's a good idea. Silly me for not seeing it.
| @@ -527,7 +527,7 @@ internal void Save(bool saveDefaultValues = false, bool immediate = false) | |||
| { | |||
|
|
|||
| Thread thread = Thread.CurrentThread; | |||
| NeosMod? callee = Util.ExecutingMod(); | |||
| NeosMod? callee = Util.ExecutingMod(new(1)); | |||
There was a problem hiding this comment.
new(1) is a stack trace? 0.o .NET syntax is weird, I assume this has just omitted the StackTrace part and it's implied...?
There was a problem hiding this comment.
Yes, the compiler knows a StackTrace is the only type that can go there, so we can omit the explicit type in the constructor call. This is equivalent to new StackTrace(1).
# Conflicts: # NeosModLoader/Util.cs
ljoonal
approved these changes
Mar 11, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does the following:
AppDomain.GetAssemblies(). It turns out that .NET calls this a lot internally, and my logic that was supposed to be intercepting FrooxEngine calls was also messing with internal .NET calls not initiated by FrooxEngine. I've implemented a smarter stack frame search to solve this.