added tests for batch operations #331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IvanAdamovNeon
force-pushed
the
NDEV-1523-batch-operations-tests
branch
2 times, most recently
from
df600e6 to
d089113
Compare
| """ | ||
| account = self.accounts[0] | ||
| evm_version: Version = self.web3_client.get_evm_version_number() | ||
| data_or_input_field_name = "data" if evm_version < Version("1.13.0") else "input" |
There was a problem hiding this comment.
Can you please explain why this condition is here?
There was a problem hiding this comment.
the up-to-date documentation states that eth_call params expect field "input"
https://ethereum.org/en/developers/docs/apis/json-rpc/#eth_call
but it turned out that with older evm versions, the field has to be "data"
ethereum/go-ethereum#28608 (comment)
There was a problem hiding this comment.
but it's not our evm version
it's go ethereum
You check version or neon evm
You can check here only current behavior
| self, | ||
| request: pytest.FixtureRequest, | ||
| common_contract, | ||
| json_rpc_client: JsonRPCSession, |
There was a problem hiding this comment.
looks like you don't use json_rpc_client here and common_contract
IvanAdamovNeon
force-pushed
the
NDEV-1523-batch-operations-tests
branch
from
d089113 to
f63acae
Compare
IvanAdamovNeon
force-pushed
the
NDEV-1523-batch-operations-tests
branch
2 times, most recently
from
8abef21 to
8417e07
Compare
kristinaNikolaevaa
approved these changes
May 10, 2024
IvanAdamovNeon
force-pushed
the
NDEV-1523-batch-operations-tests
branch
from
8417e07 to
4d725a8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.